[U-Boot] [PATCH 13/51] cfi_flash: Clean up code some more

Mario Six mario.six at gdsys.cc
Wed Jul 19 08:30:40 UTC 2017


Hi Simon,

On Tue, Jul 18, 2017 at 4:02 PM, Simon Glass <sjg at chromium.org> wrote:
> On 14 July 2017 at 05:54, Mario Six <mario.six at gdsys.cc> wrote:
>> Fix some more style violations (mostly mis-indented case statements),
>> and reduce the scope of some variables.
>>
>> Signed-off-by: Mario Six <mario.six at gdsys.cc>
>> ---
>>
>>  drivers/mtd/cfi_flash.c | 610 ++++++++++++++++++++++++------------------------
>>  1 file changed, 305 insertions(+), 305 deletions(-)
>
> Big change, but it looks right to me if I haven't missed something.
>
> Reviewed-by: Simon Glass <sjg at chromium.org>

Yeah, it looks big, but the vast majority are white space changes.

git show -w COMMITID

helps a lot here.

I also neglected to mention the changes to early-return style in the commit
message. Will fix in v2.

Best regards,

Mario


More information about the U-Boot mailing list