[U-Boot] [PATCH 23/41] Convert CONFIG_CMD_SH_ZIMAGEBOOT to Kconfig

Bin Meng bmeng.cn at gmail.com
Sat Jul 22 16:26:45 UTC 2017


Hi Simon,

On Sat, Jul 22, 2017 at 7:11 AM, Simon Glass <sjg at chromium.org> wrote:
> This converts the following to Kconfig:
>    CONFIG_CMD_SH_ZIMAGEBOOT
>
> Signed-off-by: Simon Glass <sjg at chromium.org>
> ---
>
>  arch/sh/Kconfig                   | 2 ++
>  arch/sh/lib/Kconfig               | 5 +++++
>  configs/r2dplus_defconfig         | 1 +
>  configs/sh7785lcr_32bit_defconfig | 1 +
>  configs/sh7785lcr_defconfig       | 1 +
>  include/configs/r2dplus.h         | 1 -
>  include/configs/sh7785lcr.h       | 2 --
>  scripts/config_whitelist.txt      | 1 -
>  8 files changed, 10 insertions(+), 4 deletions(-)
>  create mode 100644 arch/sh/lib/Kconfig
>
> diff --git a/arch/sh/Kconfig b/arch/sh/Kconfig
> index 6ac22af2f1..d20761e66c 100644
> --- a/arch/sh/Kconfig
> +++ b/arch/sh/Kconfig
> @@ -125,6 +125,8 @@ config SYS_CPU
>         default "sh3" if CPU_SH3
>         default "sh4" if CPU_SH4
>
> +source "arch/sh/lib/Kconfig"
> +
>  source "board/alphaproject/ap_sh4a_4a/Kconfig"
>  source "board/espt/Kconfig"
>  source "board/mpr2/Kconfig"
> diff --git a/arch/sh/lib/Kconfig b/arch/sh/lib/Kconfig
> new file mode 100644
> index 0000000000..5142cb1af2
> --- /dev/null
> +++ b/arch/sh/lib/Kconfig
> @@ -0,0 +1,5 @@
> +config CMD_SH_ZIMAGEBOOT
> +       bool "Boot a zImage on SH"

Shouldn't it be: "zimageboot - Boot a zImage on SH"

And I think this should be "default y" otherwise it's not useful. This
eliminates the need to update SH boards defconfig files.

> +       help
> +         This is special SH-specific command to boot a zImage (compressed
> +         Linux image) on SH-architecture boards.

[snip]

Regards,
Bin


More information about the U-Boot mailing list