[U-Boot] [u-boot-denx-usb] Build break on current u-boot-usb master

[Łukasz Majewski]

Hi Marek,

When I was "cleaning up" my patchwork todo list I've found following 
problem (s):

A lot of boards are broken with message:

   LD      u-boot
drivers/usb/host/built-in.o: In function `xhci_dwc3_remove':
/home/lukma/work/embedded/u-boot-denx/drivers/usb/host/xhci-dwc3.c:161: 
undefined reference to `generic_phy_exit'
drivers/usb/host/built-in.o: In function `xhci_dwc3_probe':
/home/lukma/work/embedded/u-boot-denx/drivers/usb/host/xhci-dwc3.c:127: 
undefined reference to `generic_phy_get_by_index'
/home/lukma/work/embedded/u-boot-denx/drivers/usb/host/xhci-dwc3.c:134: 
undefined reference to `generic_phy_init'
/opt/tfk-sc58x/2.3/sysroots/x86_64-pokysdk-linux/usr/bin/arm-poky-linux-gnueabi/arm-poky-linux-gnueabi-ld.bfd: 
BFD (GNU Binutils) 2.28.0.20170307 assertion fail ../../bfd/elf32-arm.c:9512
/opt/tfk-sc58x/2.3/sysroots/x86_64-pokysdk-linux/usr/bin/arm-poky-linux-gnueabi/arm-poky-linux-gnueabi-ld.bfd: 
BFD (GNU Binutils) 2.28.0.20170307 assertion fail ../../bfd/elf32-arm.c:9512
/opt/tfk-sc58x/2.3/sysroots/x86_64-pokysdk-linux/usr/bin/arm-poky-linux-gnueabi/arm-poky-linux-gnueabi-ld.bfd: 
BFD (GNU Binutils) 2.28.0.20170307 assertion fail ../../bfd/elf32-arm.c:9512
Makefile:1248: recipe for target 'u-boot' failed

The branch is:

u-boot-usb/master


I've tried to do "bisect" but another error showed up:

drivers/usb/host/xhci-dwc3.c: In function ‘xhci_dwc3_probe’:
drivers/usb/host/xhci-dwc3.c:109:29: warning: unused variable ‘plat’ 
[-Wunused-variable]
   struct xhci_dwc3_platdata *plat = dev_get_platdata(dev);
                              ^~~~
drivers/usb/host/xhci-dwc3.c: At top level:
drivers/usb/host/xhci-dwc3.c:143:37: error: invalid application of 
‘sizeof’ to incomplete type ‘struct xhci_dwc3_platdata’
   .platdata_auto_alloc_size = sizeof(struct xhci_dwc3_platdata),
                                      ^~~~~~
scripts/Makefile.build:280: recipe for target 
'drivers/usb/host/xhci-dwc3.o' failed
make[1]: *** [drivers/usb/host/xhci-dwc3.o] Error 1


Patrice and Bin - please fix those errors and make the u-boot-usb tree
bisectable again.

The last working commit:


commit 041a8808fd06b4a276dd6fbbb5153deb3b5d391c
Author: Masahiro Yamada <yamada.masahiro at socionext.com>
Date:   Thu Jun 22 16:35:14 2017 +0900

     usb: add static to local symbols

     Sparse reports "... was not declared. Should it be static?"

     Signed-off-by: Masahiro Yamada <yamada.masahiro at socionext.com>


For easy reproduction please use odroid-xu3_defconfig.

-- 
Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de