[U-Boot] [PATCH 27/41] Convert CONFIG_CMD_STRINGS to Kconfig

[Bin Meng]

On Sat, Jul 22, 2017 at 7:11 AM, Simon Glass <sjg at chromium.org> wrote:
> This converts the following to Kconfig:
>    CONFIG_CMD_STRINGS
>
> Signed-off-by: Simon Glass <sjg at chromium.org>
> ---
>
>  cmd/Kconfig                  | 8 ++++++++
>  include/configs/vct.h        | 1 -
>  scripts/config_whitelist.txt | 1 -
>  3 files changed, 8 insertions(+), 2 deletions(-)
>

Reviewed-by: Bin Meng <bmeng.cn at gmail.com>

But one comment below:

> diff --git a/cmd/Kconfig b/cmd/Kconfig
> index c3a2d1efbc..29c80feedf 100644
> --- a/cmd/Kconfig
> +++ b/cmd/Kconfig
> @@ -486,6 +486,14 @@ config CMD_MEMINFO
>         help
>           Display memory information.
>
> +config CMD_STRINGS

I feel the ordering is not correct here since I am sure we previously
have command that has R, but we are following M.

> +       bool "strings - display strings in memory"
> +       help
> +         This works similarly to the Unix 'strings' command except that it
> +         works with a memory range. String of printable characters found
> +         within the range are displayed. The minimum number of characters
> +         for a sequence to be considered a string can be provided.
> +
>  endmenu
>
>  menu "Compression commands"
> diff --git a/include/configs/vct.h b/include/configs/vct.h
> index 07e2d9e898..9d2194c807 100644
> --- a/include/configs/vct.h
> +++ b/include/configs/vct.h
> @@ -247,7 +247,6 @@ int vct_gpio_get(int pin);
>   * (NOR/OneNAND) usage and Linux kernel booting.
>   */
>  #if defined(CONFIG_VCT_SMALL_IMAGE)
> -#undef CONFIG_CMD_STRINGS
>  #undef CONFIG_CMD_TERMINAL
>
>  #undef CONFIG_SMC911X
> diff --git a/scripts/config_whitelist.txt b/scripts/config_whitelist.txt
> index ce044be4ef..21a01efd7c 100644
> --- a/scripts/config_whitelist.txt
> +++ b/scripts/config_whitelist.txt
> @@ -296,7 +296,6 @@ CONFIG_CM922T_XA10
>  CONFIG_CMDLINE_EDITING
>  CONFIG_CMDLINE_PS_SUPPORT
>  CONFIG_CMDLINE_TAG
> -CONFIG_CMD_STRINGS
>  CONFIG_CMD_SX151X
>  CONFIG_CMD_TCA642X
>  CONFIG_CMD_TERMINAL
> --

Regards,
Bin