[U-Boot] [PATCH] efi_loader: log EFI return values too

[Alexander Graf]

On 24.07.17 13:59, Rob Clark wrote:
> Turns out this is rather useful to tracking down where things fail.
> 
> Signed-off-by: Rob Clark <robdclark at gmail.com>
> ---
> I've been carrying this around locally for a while.. but I find it
> useful and I expect others would too.
> 
>   include/efi_loader.h | 5 ++++-
>   1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/include/efi_loader.h b/include/efi_loader.h
> index 043b29edd3..98d69a6dab 100644
> --- a/include/efi_loader.h
> +++ b/include/efi_loader.h
> @@ -20,7 +20,10 @@
>   	debug("EFI: Entry %s(" format ")\n", __func__, ##__VA_ARGS__); \
>   	} while(0)
>   
> -#define EFI_EXIT(ret) efi_exit_func(ret);
> +#define EFI_EXIT(ret) ({ \

For consistency, please follow the same construct as in EFI_ENTRY().

> +	debug("EFI: Exit: %s: %u\n", __func__, (u32)((ret) & 0xffff)); \

I guess you just want to mask out EFI_ERROR_MASK?


Alex