[U-Boot] [PATCH] imx6: Add support for Phytec pfla02 (NAND)

[Stefano Babic]

Hi Fabio,

On 24/07/2017 14:37, Fabio Estevam wrote:
> Hi Stefano,
> 
> On Mon, Jul 24, 2017 at 7:13 AM, Stefano Babic <sbabic at denx.de> wrote:
> 
>> +int board_mmc_getcd(struct mmc *mmc)
>> +{
>> +       struct fsl_esdhc_cfg *cfg = (struct fsl_esdhc_cfg *)mmc->priv;
>> +       int ret = 0;
>> +
>> +       switch (cfg->esdhc_base) {
>> +       case USDHC2_BASE_ADDR:
>> +               ret = !gpio_get_value(USDHC2_CD_GPIO);
> 
> Is this GPIO read really needed?
> 
>> +               ret = 1;
> 

GPIO is correct, but value should not be overwritten - thanks, I fix it
in V2.

> as it is overwritten here.
> 
>> +#define PHYS_SDRAM_SIZE                (1u * 1024 * 1024 * 1024)
> 
> This definition seems to be unused.


Youz're right, I drop it.

Best regards,
Stefano


-- 
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================