[U-Boot] [PATCH] zynq: fb_mmc: Correct cast of address to u32

Ɓukasz Majewski lukma at denx.de
Mon Jul 24 13:28:50 UTC 2017


On 07/24/2017 02:53 PM, Marek Vasut wrote:
> On 07/24/2017 02:47 PM, Tom Rini wrote:
>> On Mon, Jul 24, 2017 at 02:09:56PM +0200, Marek Vasut wrote:
>>> On 07/23/2017 05:47 PM, Tom Rini wrote:
>>>> On Sun, Jul 23, 2017 at 09:05:31AM -0600, Simon Glass wrote:
>>>>
>>>>> This does not work on 64-bit machines. Update it to use ulong.
>>>>>
>>>>> This fixes the following warnings in some zynq boards;
>>>>>
>>>>> common/fb_mmc.c: In function 'fb_mmc_update_zimage':
>>>>> common/fb_mmc.c:188:13: warning: cast from pointer to integer of different
>>>>> 	size [-Wpointer-to-int-cast]
>>>>> common/fb_mmc.c:189:8: warning: cast to pointer from integer of different
>>>>> 	size [-Wint-to-pointer-cast]
>>>>>
>>>>> Signed-off-by: Simon Glass <sjg at chromium.org>
>>>>
>>>> I fixed this in a slightly different way a while ago and am waiting for
>>>> it to come in via the USB tree currently.
>>>
>>> MMC patch via USB ? Anyway, this should use uintptr_t I guess ?
>>
>> "fastboot" is USB gadget code, and comes via Lukasz.  Unless you want me
>> to pick it up directly?  Thanks!
>>
> The tags didn't indicate any such thing and I didn't see the entire
> patch since it was clipped, so ... anyway, if it's fastboot, it indeed
> goes via Lukasz.
>

The fb_mmc.c is a bit misleading.

I will take this patch when we fix issues with u-boot-usb tree.

-- 
Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de


More information about the U-Boot mailing list