[U-Boot] [PATCH 0/4] Fix compile failure encountered on u-boot-usb tree (2017-07-20)

Marek Vasut marex at denx.de
Tue Jul 25 09:13:25 UTC 2017


On 07/25/2017 12:50 AM, Bin Meng wrote:
> Hi Marek,

Hi Bin,

> On Tue, Jul 25, 2017 at 1:32 AM, Marek Vasut <marex at denx.de> wrote:
>> On 07/24/2017 05:07 PM, patrice.chotard at st.com wrote:
>>> From: Patrice Chotard <patrice.chotard at st.com>
>>>
>>> This series fixes :
>>>       _ compilation issue reported by Ran Wang on u-boot-usb branch
>>>       _ add last minute fixes for both generic-ehci and generic_ohci drivers
>>>         which avoid to init a generic PHY if not found, reported by Patrick
>>>         Delaunay
>>>
>>> This series need an additionnal patch from Jean-Jacques Hiblot :
>>> [PATCH v2] phy: add a NO-OP phy driver
>>>
>>>
>>> Patrice Chotard (4):
>>>   dm: phy: add missing #ifdef CONFIG_PHY
>>>   dm: usb: host: xhci-dwc3: add missing #ifdef CONFIG_DM_USB
>>>   usb: host: ehci-generic: initialize PHY only when found
>>>   usb: host: ohci-generic: initialize PHY only when found
>>>
>>>  drivers/usb/host/ehci-generic.c | 11 ++++++-----
>>>  drivers/usb/host/ohci-generic.c | 11 ++++++-----
>>>  drivers/usb/host/xhci-dwc3.c    |  2 ++
>>>  include/generic-phy.h           | 42 +++++++++++++++++++++++++++++++++++++++++
>>>  4 files changed, 56 insertions(+), 10 deletions(-)
>>>
>> Applied all, thanks.
>>
> 
> I see these 4 patches are applied on top of u-boot-usb/master
> directly. I think they should be squashed into Patrice's previous
> patches, so that we can still maintain bisectablity.

They can, but then I have to rewrite history and rebase your patches on
top of his, which I'm not too happy to do. Plus if I squash them, you
cannot locate either of the squashed patches in the ML, which sucks.

> Regards,
> Bin
> 


-- 
Best regards,
Marek Vasut


More information about the U-Boot mailing list