[U-Boot] [PATCH 38/51] gdsys: drivers: Add gdsys_rxaui_ctrl driver

[Mario Six]

Hi Simon,

On Wed, Jul 19, 2017 at 11:06 AM, Simon Glass <sjg at chromium.org> wrote:
> Hi Mario,
>
> On 14 July 2017 at 05:55, Mario Six <mario.six at gdsys.cc> wrote:
>> Add a driver for RXAUI control on IHS FPGAs.
>>
>> Signed-off-by: Mario Six <mario.six at gdsys.cc>
>> ---
>>
>>  drivers/misc/Kconfig            |   6 +++
>>  drivers/misc/Makefile           |   1 +
>>  drivers/misc/gdsys_rxaui_ctrl.c | 107 ++++++++++++++++++++++++++++++++++++++++
>>  include/dm/uclass-id.h          |   1 +
>>  include/gdsys_rxaui_ctrl.h      |  66 +++++++++++++++++++++++++
>>  5 files changed, 181 insertions(+)
>>  create mode 100644 drivers/misc/gdsys_rxaui_ctrl.c
>>  create mode 100644 include/gdsys_rxaui_ctrl.h
>
> Can we use generic PHY for this and add a few operations? Or should we
> create a new phy type?
>

I think a ethernet-specific phy uclass is probably a good idea here, though I'm
not perfectly sure. Someone with more knowledge about the network subsystem can
probably answer that question better than me.

> In general with DM we should not add driver-specific uclasses. There
> are cases where is makes sense and it's hard to predict the future,
> but you can imagine ending up with a huge number of APIs if we don't
> manager to share.
>

OK, I wasn't really sure about that. Thanks for clarifying.

> Regards.
> Simon

Best regards,

Mario