[U-Boot] [PATCH 42/51] cmd: Add ihs fpga command

[Mario Six]

Hi Simon,

On Wed, Jul 19, 2017 at 11:06 AM, Simon Glass <sjg at chromium.org> wrote:
> Hi Mario,
>
> On 14 July 2017 at 05:55, Mario Six <mario.six at gdsys.cc> wrote:
>> Add a comman to debug the IHS FPGA's bus.
>>
>> Signed-off-by: Mario Six <mario.six at gdsys.cc>
>> ---
>>
>>  cmd/Kconfig    |   5 ++
>>  cmd/Makefile   |   1 +
>>  cmd/ihs_fpga.c | 269 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>>  3 files changed, 275 insertions(+)
>>  create mode 100644 cmd/ihs_fpga.c
>
> This should be more generic as per the driver - e.g. a read/write()
> method that supports an access size parameter.
>

For a generic FPGA uclass, yes, definitely. Will fix in v2.

> Is there any way we can make some of the code common with things like 'md'?
>

You mean share code between all the commands that read/write to memory-like
devices? Probably. I'll take a look. Any preference where the common code
should be kept? In cmd/ ?

>>
>> diff --git a/cmd/Kconfig b/cmd/Kconfig
>> index 4bbe9d435c..6d13c681cb 100644
>> --- a/cmd/Kconfig
>> +++ b/cmd/Kconfig
>> @@ -753,6 +753,11 @@ config CMD_SATA
>>           Attachment, where AT refers to an IBM AT (Advanced Technology)
>>           computer released in 1984.
>>
>> +config CMD_IHS_FPGA
>> +       bool "fpga"
>> +       help
>> +         Enable the GDSYS IHS FPGA command for accessing the FPGA's regisers.
>> +
>
> Regards,
> Simon

Best regards,

Mario