[U-Boot] [PATCH v4 18/20] dm: power: Convert as3722 to driver model

[Simon Glass]

Hi Marcel,

On 13 July 2017 at 02:38, Marcel Ziswiler <marcel.ziswiler at toradex.com> wrote:
> On Tue, 2017-07-11 at 21:30 -0600, Simon Glass wrote:
>> Convert this PMIC driver to driver model and fix up other users. The
>> regulator and GPIO functions are now handled by separate drivers.
>>
>> Update nyan-big to work correct. Three boards will need to be updated
>> by
>> the maintainers: apalis-tk1, jetson-tk1, cei-tk1-som
>>
>> Signed-off-by: Simon Glass <sjg at chromium.org>
>> Reviewed-by: Lukasz Majewski <lukma at denx.de>
>> ---
>>
>> Changes in v4: None
>> Changes in v3: None
>> Changes in v2: None
>>
>>  arch/arm/mach-tegra/board2.c          |   6 -
>>  board/cei/cei-tk1-som/cei-tk1-som.c   |   2 +
>>  board/nvidia/jetson-tk1/jetson-tk1.c  |   2 +
>>  board/nvidia/nyan-big/nyan-big.c      |  22 +--
>>  board/toradex/apalis-tk1/apalis-tk1.c |   6 +
>>  configs/apalis-tk1_defconfig          |   3 +
>>  configs/cei-tk1-som_defconfig         |   3 +
>>  configs/jetson-tk1_defconfig          |   3 +
>>  configs/nyan-big_defconfig            |   1 +
>>  drivers/power/pmic/Makefile           |   2 +-
>>  drivers/power/pmic/as3722.c           | 292 ++++++++++++----------
>> ------------
>>  include/power/as3722.h                |  18 +--
>>  12 files changed, 133 insertions(+), 227 deletions(-)

[..]

>> diff --git a/board/nvidia/jetson-tk1/jetson-tk1.c
>> b/board/nvidia/jetson-tk1/jetson-tk1.c
>> index a66b710cdd..48272d086c 100644
>> --- a/board/nvidia/jetson-tk1/jetson-tk1.c
>> +++ b/board/nvidia/jetson-tk1/jetson-tk1.c
>> @@ -39,6 +39,7 @@ void pinmux_init(void)
>>  #ifdef CONFIG_PCI_TEGRA
>>  int tegra_pcie_board_init(void)
>>  {
>> +/* TODO: Convert to driver model
>
> Is that still applicable or how was that one solved at the end?

I'm going to add back the work-around code in v5. But this code still
need porting to DM. I am hoping that someone else can take on this
work.

>
>>       struct udevice *pmic;
>>       int err;
>>
>> @@ -59,6 +60,7 @@ int tegra_pcie_board_init(void)
>>               error("failed to set SD4 voltage: %d\n", err);
>>               return err;
>>       }
>> +*/
>>
>>       return 0;
>>  }

Regards,
Simon