[U-Boot] [PATCH v2 26/34] env: Drop unused env_ptr variables

Tom Rini trini at konsulko.com
Wed Jul 26 16:14:44 UTC 2017


On Sun, Jul 23, 2017 at 09:20:01PM -0600, Simon Glass wrote:

> This variable is declared as a global in most environment location
> drivers. But it is not used outside the drivers and most of the
> declarations are unnecessary.
> 
> Also some drivers call free() on env_ptr which seems wrong since it is
> not in the heap.
> 
> Drop the variable where possible, and all calls to free().
> 
> Signed-off-by: Simon Glass <sjg at chromium.org>

Reviewed-by: Tom Rini <trini at konsulko.com>

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170726/13e032c0/attachment.sig>


More information about the U-Boot mailing list