[U-Boot] [PATCH] efi_loader: add some missing breaks

Heinrich Schuchardt xypron.glpk at gmx.de
Fri Jul 28 10:58:51 UTC 2017


On 07/27/2017 05:28 PM, Rob Clark wrote:
> Signed-off-by: Rob Clark <robdclark at gmail.com>
> ---
> Just noticed that there didn't seem to be quite enough break's.  Pretty
> sure the intention wasn't to fall-thru
> 
>  lib/efi_loader/efi_device_path_to_text.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/lib/efi_loader/efi_device_path_to_text.c b/lib/efi_loader/efi_device_path_to_text.c
> index 612e380617..4b2f43f0c8 100644
> --- a/lib/efi_loader/efi_device_path_to_text.c
> +++ b/lib/efi_loader/efi_device_path_to_text.c
> @@ -52,6 +52,7 @@ static uint16_t *efi_convert_device_node_to_text(
>  			break;
>  			}
>  		}
> +		break;
>  	case DEVICE_PATH_TYPE_MEDIA_DEVICE:
>  		switch (device_node->sub_type) {
>  		case DEVICE_PATH_SUB_TYPE_FILE_PATH:
> @@ -63,6 +64,7 @@ static uint16_t *efi_convert_device_node_to_text(
>  			memcpy(buffer, device_node->data, buffer_size);
>  			break;
>  		}
> +		break;
>  	}
>  
>  	/*
> 

Thank you for catching this.

Reviewed-by: Heinrich Schuchardt <xypron.glpk at gmx.de>


More information about the U-Boot mailing list