[U-Boot] [PATCH 0/3] env_embedded related fixes/improvements

[Thomas Petazzoni]

Hello,

Here is a small patch series that fixes the build on SuperH when
CONFIG_ENV_IS_NOWHERE is set (first patch) and then does some
follow-up cleanups in common/env_embedded.c.

However, I would like to ask for a careful review to be made here,
since the whole environment handling logic is still not clear to me.

For example, I don't quite get why common/Makefile looks like this:

obj-$(CONFIG_ENV_IS_IN_DATAFLASH) += env_dataflash.o
obj-$(CONFIG_ENV_IS_IN_EEPROM) += env_eeprom.o
extra-$(CONFIG_ENV_IS_EMBEDDED) += env_embedded.o
obj-$(CONFIG_ENV_IS_IN_EEPROM) += env_embedded.o
extra-$(CONFIG_ENV_IS_IN_FLASH) += env_embedded.o

Why when CONFIG_ENV_IS_IN_FLASH is used, env_embedded is built, but
not integrated at link time ? Is it the responsibility of the linker
script to include it ? Why is it done so ? Very few linker scripts in
U-Boot actually include env_embedded.o.

Thanks,

Thomas

Thomas Petazzoni (3):
  arch/sh: don't bring common/env_embedded.o into the link
  common/env_embedded.c: drop support for CONFIG_SYS_USE_PPCENV
  common/env_embedded.c: rename PPCENV/PPCTEXT macros

 arch/sh/cpu/u-boot.lds |  4 ----
 common/env_embedded.c  | 23 +++++++----------------
 include/env_default.h  |  2 +-
 3 files changed, 8 insertions(+), 21 deletions(-)

-- 
2.9.4