[U-Boot] [PATCH 1/1] Add support Raspberry-Pi Ziro W

[Rask Ingemann Lambertsen]

On Thu, Jul 27, 2017 at 11:42:36PM +0400, Dmitry Korunov wrote:
> Signed-off-by: Dmitry Korunov <dessel.k at gmail.com>

How about a summary of the board?

CPU
Memory
Storage
USB
Wi-fi
Ethernet
etc.

> ---
>  arch/arm/dts/bcm2835-rpi-zero-w.dts    | 44 ++++++++++++++++++++++++++++++++++
>  arch/arm/dts/bcm283x-rpi-usb-host.dtsi |  3 +++
>  arch/arm/mach-bcm283x/Kconfig          | 16 +++++++++++++
>  board/raspberrypi/rpi/rpi.c            |  5 ++++
>  configs/rpi_0_w_defconfig              | 28 ++++++++++++++++++++++
>  include/configs/rpi.h                  |  2 +-
>  6 files changed, 97 insertions(+), 1 deletion(-)
>  create mode 100644 arch/arm/dts/bcm2835-rpi-zero-w.dts
>  create mode 100644 arch/arm/dts/bcm283x-rpi-usb-host.dtsi
>  create mode 100644 configs/rpi_0_w_defconfig
> 
> diff --git a/arch/arm/dts/bcm2835-rpi-zero-w.dts b/arch/arm/dts/bcm2835-rpi-zero-w.dts
> new file mode 100644
> index 0000000..c63937d
> --- /dev/null
> +++ b/arch/arm/dts/bcm2835-rpi-zero-w.dts
> @@ -0,0 +1,44 @@
> +/*
> + * Copyright (C) 2016 Stefan Wahren <stefan.wahren at i2se.com>

Is this still correct?

> --- a/arch/arm/mach-bcm283x/Kconfig
> +++ b/arch/arm/mach-bcm283x/Kconfig
> @@ -44,6 +44,22 @@ config TARGET_RPI
>  	  This option creates a build targetting the ARM1176 ISA.
>  	select BCM2835
>  
> +config TARGET_RPI_0_W
> +	bool "Raspberry Pi Ziro  W"

Surplus space before W.

> +	help
> +	  Support for all ARM1176-/BCM2835-based Raspberry Pi variants, such as
> +	  the RPi Zero model W.

So which is it? "Ziro W" or "Zero W"? Your commit message summary says "Ziro
W" but your patch is mostly about the "Zero W".

> +
> +	  This option assumes the VideoCore firmware is configured to use the
> +	  mini UART (rather than PL011) for the serial console. This is the
> +	  default on the RPi Zero W. To enable the UART console, the following
> +	  non-default option must be present in config.txt: enable_uart=1.
> +	  This is required for U-Boot to operate correctly, even if you only
> +	  care about the HDMI/usbkbd console.
> +
> +	  This option creates a build targetting the ARMv7/AArch32 ISA.
> +	select BCM2835
> +
>  config TARGET_RPI_2
>  	bool "Raspberry Pi 2"
>  	help
> diff --git a/include/configs/rpi.h b/include/configs/rpi.h
> index d715eaa..0ead8d7 100644
> --- a/include/configs/rpi.h
> +++ b/include/configs/rpi.h
> @@ -80,7 +80,7 @@
>  #endif
>  
>  /* Console UART */
> -#ifdef CONFIG_BCM2837
> +#if  defined (CONFIG_BCM2837) || defined(CONFIG_TARGET_RPI_0_W)

Another surplus space.

-- 
Rask Ingemann Lambertsen