[U-Boot] [PATCH 1/1] ARM: hisilicon: hikey: do not rely on random stack value

Heinrich Schuchardt xypron.glpk at gmx.de
Sun Jul 30 19:30:55 UTC 2017


If CONFIG_MMC_DW is not defined the return value of
init_dwmmc should not rely on a random stack value.

Instead indicate that no error occured.

The problem was indicated by cppcheck.

Signed-off-by: Heinrich Schuchardt <xypron.glpk at gmx.de>
---
 board/hisilicon/hikey/hikey.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/board/hisilicon/hikey/hikey.c b/board/hisilicon/hikey/hikey.c
index 47bce4daa6..c513d0af10 100644
--- a/board/hisilicon/hikey/hikey.c
+++ b/board/hisilicon/hikey/hikey.c
@@ -345,7 +345,7 @@ int board_init(void)
 
 static int init_dwmmc(void)
 {
-	int ret;
+	int ret = 0;
 
 #ifdef CONFIG_MMC_DW
 
-- 
2.13.2



More information about the U-Boot mailing list