[U-Boot] [PATCH 1/1] armv7m: mpu_config add missing break

Vikas Manocha vikas.manocha at st.com
Mon Jul 31 18:18:52 UTC 2017


Hi,

On 07/30/2017 11:34 AM, Heinrich Schuchardt wrote:
> For DEVICE_NON_SHARED the newly assigned value of attr
> is overwritten due to a missing break.
> 
> The problem was indicated by cppcheck.
> 
> Signed-off-by: Heinrich Schuchardt <xypron.glpk at gmx.de>

reviewed-by : Vikas Manocha <vikas.manocha at st.com>

Cheers,
Vikas

> ---
>  arch/arm/cpu/armv7m/mpu.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm/cpu/armv7m/mpu.c b/arch/arm/cpu/armv7m/mpu.c
> index 31a243b49a..4622aa4826 100644
> --- a/arch/arm/cpu/armv7m/mpu.c
> +++ b/arch/arm/cpu/armv7m/mpu.c
> @@ -68,6 +68,7 @@ void mpu_config(struct mpu_region_config *reg_config)
>  		break;
>  	case DEVICE_NON_SHARED:
>  		attr = (2 << TEX_SHIFT) | BUFFERABLE;
> +		break;
>  	default:
>  		attr = 0; /* strongly ordered */
>  		break;
> 


More information about the U-Boot mailing list