[U-Boot] sf: Remove spansion_s25fss_disable_4KB_erase

[Suresh Gupta]

Hi Jagan, 

As already discussed in this forum that flash "S25FS512S" have Hybrid sector option and to come out of this hybrid mode we required 
"spansion_s25fss_disable_4KB_erase" patch in which  we set bit 3 of "Configuration Register 3 Non-Volatile (CR3NV)/ Configuration Register-3 Volatile (CR3V)".
This disable 4-kB Erase and configure flash in Uniform Sector Architecture. 

After removing this patch, we are facing issues in erasing initial sectors of flash. 
Please let me know what is your plan to fix this issue, Can I send patch again ?   

Thanks 
SuresH

> -----Original Message-----
> From: york sun
> Sent: Friday, March 31, 2017 5:50 AM
> To: Suresh Gupta <suresh.gupta at nxp.com>
> Cc: Mingkai Hu <mingkai.hu at nxp.com>; Jagan Teki
> <jagannadh.teki at gmail.com>; Jagan Teki <jagan at openedev.com>; u-
> boot at lists.denx.de
> Subject: Re: [U-Boot] sf: Remove spansion_s25fss_disable_4KB_erase
> 
> On 03/27/2017 06:12 PM, Mingkai Hu wrote:
> >
> >> -----Original Message-----
> >> From: Jagan Teki [mailto:jagannadh.teki at gmail.com]
> >> Sent: Tuesday, March 28, 2017 1:57 AM
> >> To: york sun <york.sun at nxp.com>
> >> Cc: Jagan Teki <jagan at openedev.com>; u-boot at lists.denx.de; Mingkai Hu
> >> <mingkai.hu at nxp.com>
> >> Subject: Re: [U-Boot] sf: Remove spansion_s25fss_disable_4KB_erase
> >>
> >> On Mon, Mar 27, 2017 at 11:05 PM, york sun <york.sun at nxp.com> wrote:
> >>> On 03/15/2017 06:44 PM, york.sun at nxp.com wrote:
> >>>> On 01/27/2017 10:04 AM, Jagan Teki wrote:
> >>>>> On Mon, Jan 23, 2017 at 8:05 PM, york sun <york.sun at nxp.com> wrote:
> >>>>>> On 12/12/2016 09:32 PM, Yao Yuan wrote:
> >>>>>>> Hi Jagan,
> >>>>>>>
> >>>>>>>
> >>>>>>>
> >>>>>>> Do you have any comments?
> >>>>>>>
> >>>>>>>
> >>>>>>>
> >>>>>>> Thanks for your work and you know it's important for QSPI with
> >>>>>>> S25FS512S.
> >>>>>>>
> >>>>>>>
> >>>>>>>
> >>>>>>> It seems S25FS512S can't support the SECT_4K, right?
> >>>>>>>
> >>>>>>> And it better to retain the disable_4kb, but we can add a flag
> >>>>>>> in dts to select whether enable it.
> >>>>>>>
> >>>>>>>
> >>>>>>
> >>>>>> Jagan,
> >>>>>>
> >>>>>> This is blocking me from using the board with this specific flash chip.
> >>>>>> Can you take a look? By reverting this single commit 116e005c, my
> >>>>>> board works again.
> >>>>>
> >>>>> I will try to work on this.
> >>>>>
> >>>>
> >>>> Guys,
> >>>>
> >>>> Where are we on this issue?
> >>>>
> >>>> York
> >>>>
> >>>
> >>> Can we revert this patch or have a fix?
> >>
> >> Just wanted to understand more about this, I've attached programming
> >> model in previous mail about this and based on that I've fixed with all 4K.
> >> Waiting for 'Yao Yuan' inputs on this.
> >>
> >
> > +Suresh to follow up this question.
> >
> 
> Suresh,
> 
> Can you follow up on this? This issue is blocking me from testing QSPI on
> LS1046ARDB. Even I revert this patch, I can only erase part of the flash.
> 
> York