[U-Boot] [PATCH v7 07/10] usb: dwc3: Add dwc3 glue driver support for STi

[Marek Vasut]

On 06/05/2017 08:40 AM, Patrice CHOTARD wrote:
> Hi Marek

Hi,

[...]

>>> diff --git a/include/dwc3-sti-glue.h b/include/dwc3-sti-glue.h
>>> new file mode 100644
>>> index 0000000..2083427
>>> --- /dev/null
>>> +++ b/include/dwc3-sti-glue.h
>>> @@ -0,0 +1,43 @@
>>> +/*
>>> + * Copyright (c) 2017
>>> + * Patrice Chotard <patrice.chotard at st.com>
>>> + *
>>> + * SPDX-License-Identifier:	GPL-2.0+
>>> + */
>>> +
>>> +#ifndef __DWC3_STI_UBOOT_H_
>>> +#define __DWC3_STI_UBOOT_H_
>>> +
>>> +#include <linux/usb/otg.h>
>>
>> Does this have to be in a separate header file ?
> 
> This is needed for enum usb_dr_mode used in int sti_dwc3_init() 
> prototype below.

So just wrap it into dwc3-sti-glue.c ?

>>> +/* glue registers */
>>> +#define CLKRST_CTRL		0x00
>>> +#define AUX_CLK_EN		BIT(0)
>>> +#define SW_PIPEW_RESET_N	BIT(4)
>>> +#define EXT_CFG_RESET_N		BIT(8)
>>> +
>>> +#define XHCI_REVISION		BIT(12)
>>> +
>>> +#define USB2_VBUS_MNGMNT_SEL1	0x2C
>>> +#define USB2_VBUS_UTMIOTG	0x1
>>> +
>>> +#define SEL_OVERRIDE_VBUSVALID(n)	((n) << 0)
>>> +#define SEL_OVERRIDE_POWERPRESENT(n)	((n) << 4)
>>> +#define SEL_OVERRIDE_BVALID(n)		((n) << 8)
>>> +
>>> +/* Static DRD configuration */
>>> +#define USB3_CONTROL_MASK		0xf77
>>> +
>>> +#define USB3_DEVICE_NOT_HOST		BIT(0)
>>> +#define USB3_FORCE_VBUSVALID		BIT(1)
>>> +#define USB3_DELAY_VBUSVALID		BIT(2)
>>> +#define USB3_SEL_FORCE_OPMODE		BIT(4)
>>> +#define USB3_FORCE_OPMODE(n)		((n) << 5)
>>> +#define USB3_SEL_FORCE_DPPULLDOWN2	BIT(8)
>>> +#define USB3_FORCE_DPPULLDOWN2		BIT(9)
>>> +#define USB3_SEL_FORCE_DMPULLDOWN2	BIT(10)
>>> +#define USB3_FORCE_DMPULLDOWN2		BIT(11)
>>> +
>>> +int sti_dwc3_init(enum usb_dr_mode mode);
>>> +
>>> +#endif /* __DWC3_STI_UBOOT_H_ */
>>>
>>


-- 
Best regards,
Marek Vasut