[U-Boot] [PATCH 1/2] rockchip: video: rk_hdmi: fix implicit definition warnings

sjg at google.com sjg at google.com
Thu Jun 8 03:34:57 UTC 2017


On 6 June 2017 at 01:15, Philipp Tomsich
<philipp.tomsich at theobroma-systems.com> wrote:
> When enabling CONFIG_DISPLAY_ROCKCHIP_HDMI, compile-time warning for
> the following implicitly defined functions are raised due to a missing
> include directive:
>
>   drivers/video/rockchip/rk_hdmi.c: In function 'rk_hdmi_probe':
>   drivers/video/rockchip/rk_hdmi.c:150:2: warning: implicit declaration of function 'rk_setreg' [-Wimplicit-function-declaration]
>     rk_setreg(&priv->grf->soc_con6, 1 << 15);
>     ^~~~~~~~~
>   drivers/video/rockchip/rk_hdmi.c:153:2: warning: implicit declaration of function 'rk_clrsetreg' [-Wimplicit-function-declaration]
>     rk_clrsetreg(&priv->grf->soc_con6, 1 << 4,
>     ^~~~~~~~~~~~
>
> This change fixes this by including <asm/hardware.h> in rk_hdmi.c.
>
> Signed-off-by: Philipp Tomsich <philipp.tomsich at theobroma-systems.com>
>
> ---
>
> Changes in v3:
> - adds an include-directive to the (pre-RK3399 enabled) rk_hdmi to
>   fix implicit definition warnings
>
> Changes in v2: None
>
>  drivers/video/rockchip/rk_hdmi.c | 1 +
>  1 file changed, 1 insertion(+)

Acked-by: Simon Glass <sjg at chromium.org>

Applied to u-boot-rockchip, thanks!


More information about the U-Boot mailing list