[U-Boot] [PATCH 14/20] configs: Remove CONFIG_SYS_USB_EHCI_MAX_ROOT_PORTS in all boards

Stefan Roese sr at denx.de
Wed Jun 21 12:13:28 UTC 2017


Hi Bin,

On 16.06.2017 16:09, Bin Meng wrote:
> Hi Stefan,
> 
> On Fri, Jun 16, 2017 at 9:31 PM, Bin Meng <bmeng.cn at gmail.com> wrote:
>> Now that EHCD does not use CONFIG_SYS_USB_EHCI_MAX_ROOT_PORTS,
>> remove it in all boards' config files.
>>
>> Signed-off-by: Bin Meng <bmeng.cn at gmail.com>
>> ---
>>
>>   arch/arm/include/asm/ehci-omap.h    | 4 ----
>>   include/configs/MPC8572DS.h         | 1 -
>>   include/configs/cm_t54.h            | 1 -
>>   include/configs/corvus.h            | 3 ---
>>   include/configs/duovero.h           | 2 --
>>   include/configs/exynos5-common.h    | 2 --
>>   include/configs/ma5d4evk.h          | 1 -
>>   include/configs/mcx.h               | 1 -
>>   include/configs/mvebu_armada-37xx.h | 7 +------
>>   include/configs/mvebu_armada-8k.h   | 7 +------
>>   include/configs/mx35pdk.h           | 1 -
>>   include/configs/odroid.h            | 1 -
>>   include/configs/omap3_beagle.h      | 1 -
>>   include/configs/omap3_overo.h       | 1 -
>>   include/configs/omap4_panda.h       | 2 --
>>   include/configs/omap5_uevm.h        | 1 -
>>   include/configs/picosam9g45.h       | 3 ---
>>   include/configs/sama5d2_ptc.h       | 4 ----
>>   include/configs/snapper9g45.h       | 3 ---
>>   include/configs/sunxi-common.h      | 1 -
>>   include/configs/tam3517-common.h    | 1 -
>>   include/configs/tao3530.h           | 1 -
>>   include/configs/tegra114-common.h   | 1 -
>>   include/configs/tegra124-common.h   | 1 -
>>   include/configs/tegra20-common.h    | 1 -
>>   include/configs/tegra210-common.h   | 1 -
>>   include/configs/tegra30-common.h    | 1 -
>>   include/configs/vinco.h             | 6 ------
>>   include/configs/x86-common.h        | 1 -
>>   scripts/config_whitelist.txt        | 1 -
>>   30 files changed, 2 insertions(+), 60 deletions(-)
>>
> 
> [snip]
> 
>> diff --git a/include/configs/mvebu_armada-37xx.h b/include/configs/mvebu_armada-37xx.h
>> index 7a255a1..a9a2437 100644
>> --- a/include/configs/mvebu_armada-37xx.h
>> +++ b/include/configs/mvebu_armada-37xx.h
>> @@ -94,12 +94,7 @@
>>   #define CONFIG_NET_RETRY_COUNT 50
>>   #define CONFIG_PHY_MARVELL
>>
>> -/* USB 2.0 */
>> -#define CONFIG_SYS_USB_EHCI_MAX_ROOT_PORTS 3
>> -
>> -/* USB 3.0 */
>> -#define CONFIG_USB_MAX_CONTROLLER_COUNT (CONFIG_SYS_USB_EHCI_MAX_ROOT_PORTS + \
>> -                                        3)
>> +#define CONFIG_USB_MAX_CONTROLLER_COUNT (3 + 3)
> 
> I strongly suspect here CONFIG_USB_MAX_CONTROLLER_COUNT is mistakenly
> configured, unless each host controller only has 1 root port? Please
> review.

Yes, you seem to be correct, thanks.

Reviewed-by: Stefan Roese <sr at denx.de>

Thanks,
Stefan


More information about the U-Boot mailing list