[U-Boot] [PATCH] ARM: dts: skeleton: fix unit name warning from dtc

[Wenyou.Yang at microchip.com]

Hi Simon,

> -----Original Message-----
> From: sjg at google.com [mailto:sjg at google.com] On Behalf Of Simon Glass
> Sent: 2017年3月13日 21:24
> To: Masahiro Yamada <yamada.masahiro at socionext.com>
> Cc: Wenyou Yang - A41535 <Wenyou.Yang at microchip.com>; U-Boot Mailing
> List <u-boot at lists.denx.de>; Stephen Warren <swarren at nvidia.com>
> Subject: Re: [U-Boot] [PATCH] ARM: dts: skeleton: fix unit name warning from dtc
> 
> Hi,
> 
> On 13 March 2017 at 03:00, Masahiro Yamada
> <yamada.masahiro at socionext.com> wrote:
> > 2017-03-13 16:53 GMT+09:00 Wenyou Yang <wenyou.yang at atmel.com>:
> >> Fix the following warning from dtc by adding the unit name for the
> >> memory node.
> >> ---8<---
> >> Warning (unit_address_vs_reg): Node /memory has a reg or ranges
> >> property, but no unit name
> >> ---<8---
> >>
> >> Signed-off-by: Wenyou Yang <wenyou.yang at atmel.com>
> >> ---
> >>
> >>  arch/arm/dts/skeleton.dtsi | 2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/arch/arm/dts/skeleton.dtsi b/arch/arm/dts/skeleton.dtsi
> >> index b41d241de2..a20da0a7a6 100644
> >> --- a/arch/arm/dts/skeleton.dtsi
> >> +++ b/arch/arm/dts/skeleton.dtsi
> >> @@ -9,5 +9,5 @@
> >>         #size-cells = <1>;
> >>         chosen { };
> >>         aliases { };
> >> -       memory { device_type = "memory"; reg = <0 0>; };
> >> +       memory at 0 { device_type = "memory"; reg = <0 0>; };
> >>  };
> >> --
> >> 2.11.0
> >>
> >
> >
> >
> > As far as I can tell, the DT community decided to deprecate
> > skeleton.dtsi (and people are fixing DT files to not include it).
> >
> >
> >
> > commit 9c0da3cc61f1233c2782e2d3d91e3d0707dd4ba5
> > Author: Mark Rutland <mark.rutland at arm.com>
> > Date:   Fri Sep 2 17:34:50 2016 +0100
> >
> >     ARM: dts: explicitly mark skeleton.dtsi as deprecated
> >
> >     As noted in commit 3ebee5a2e141496b ("arm64: dts: kill skeleton.dtsi"),
> >     there are a number of problems with skeleton.dtsi, and it would be
> >     prefereable to remove it entirely. As there are a large number of
> >     existing users, fixing these up will take a while.
> >
> >     This patch adds a note to arm's skeleton.dtsi noting that this is the
> >     case, to make this more obvious and hopefully minimize new uptake of
> >     skeleton.dtsi in the mean time.
> >
> >     Signed-off-by: Mark Rutland <mark.rutland at arm.com>
> >     Acked-by: Rob Herring <robh at kernel.org>
> >     Cc: Arnd Bergmann <arnd at arndb.de>
> >     Cc: Olof Johansson <olof at lixom.net>
> >     Signed-off-by: Arnd Bergmann <arnd at arndb.de>
> >
> >
> 
> OK so perhaps a patch to mark it deprecated, and a patch to remove it from the
> Atmel boards would be better?

Thank you for your information.

I will send a patch to remove it from the Atmel boards.


Best Regards,
Wenyou Yang