[U-Boot] [PATCH v1 17/41] net: mvpp2: adapt the mvpp2_rxq_*_pool_set functions to PPv2.2

Stefan Roese sr at denx.de
Wed Mar 22 07:13:12 UTC 2017


On 21.03.2017 18:21, Joe Hershberger wrote:
> On Tue, Mar 21, 2017 at 9:27 AM, Stefan Roese <sr at denx.de> wrote:
>> From: Thomas Petazzoni <thomas.petazzoni at free-electrons.com>
>>
>> The MVPP2_RXQ_CONFIG_REG register has a slightly different layout
>> between PPv2.1 and PPv2.2, so this commit adapts the functions modifying
>> this register to accommodate for both the PPv2.1 and PPv2.2 cases.
>>
>> Signed-off-by: Thomas Petazzoni <thomas.petazzoni at free-electrons.com>
>> Signed-off-by: Stefan Roese <sr at denx.de>
>
> Acked-by: Joe Hershberger <joe.hershberger at ni.com>
>
>> ---
>>
>>  drivers/net/mvpp2.c | 19 ++++++++++++-------
>>  1 file changed, 12 insertions(+), 7 deletions(-)
>>
>> diff --git a/drivers/net/mvpp2.c b/drivers/net/mvpp2.c
>> index c5ac6d1b7f..edd985910c 100644
>> --- a/drivers/net/mvpp2.c
>> +++ b/drivers/net/mvpp2.c
>> @@ -91,9 +91,11 @@ do {                                                                 \
>>  #define     MVPP2_SNOOP_PKT_SIZE_MASK          0x1ff
>>  #define     MVPP2_SNOOP_BUF_HDR_MASK           BIT(9)
>>  #define     MVPP2_RXQ_POOL_SHORT_OFFS          20
>> -#define     MVPP2_RXQ_POOL_SHORT_MASK          0x700000
>> +#define     MVPP21_RXQ_POOL_SHORT_MASK         0x700000
>> +#define     MVPP22_RXQ_POOL_SHORT_MASK         0xf00000
>
> I guess these are just defined for completeness? Never used? Maybe
> just drop them?
>
> Obviously not important, so up to you.

Thanks for spotting. If it comes to a v2, then I'll remove those
defines.

Thanks,
Stefan


More information about the U-Boot mailing list