[U-Boot] [PATCH] imx: i.mx6q: add the initial support for LogicPD i.MX6Q SOM

[Fabio Estevam]

Hi Adam,

On Wed, Mar 22, 2017 at 7:07 PM, Adam Ford <aford173 at gmail.com> wrote:
 config SYS_SOC
> @@ -415,5 +422,6 @@ source "board/udoo/Kconfig"
>  source "board/udoo/neo/Kconfig"
>  source "board/wandboard/Kconfig"
>  source "board/warp/Kconfig"
> +source "board/logicpd/imx6/Kconfig"

Alphabetical order, please.

> --- /dev/null
> +++ b/board/logicpd/imx6/README
> @@ -0,0 +1,103 @@
> +How to use and build U-Boot on mx6sabresd:
> +----------------------------------
> +
> +Currently there are three methods for booting mx6sabresd boards:

Looks like you forgot to change the board name here :-)

> +iomux_v3_cfg_t const nand_pads[] = {

static


> +//Control:
> +DATA 4  0x020e057c 0x00000030  // IOMUXC_SW_PAD_CTL_PAD_DRAM_RESET
> +DATA 4  0x020e058c 0x00000000  // IOMUXC_SW_PAD_CTL_PAD_DRAM_SDBA2 - DSE can be configured using Group Control Register: IOMUXC_SW_PAD_CTL_GRP_CTLDS
> +DATA 4  0x020e059c 0x00000030  // IOMUXC_SW_PAD_CTL_PAD_DRAM_SDODT0
> +DATA 4  0x020e05a0 0x00000030  // IOMUXC_SW_PAD_CTL_PAD_DRAM_SDODT1
> +DATA 4  0x020e078c 0x00000030  // IOMUXC_SW_PAD_CTL_GRP_CTLDS
> +
> +//Data Strobes:

Better avoid // notation. You could use /* comment */ instead. Make
sure you run checkpatch.pl.

> +DATA 4  0x020e0750 0x00020000  // IOMUXC_SW_PAD_CTL_GRP_DDRMODE_CTL
> +DATA 4  0x020e05a8 0x00000030  // IOMUXC_SW_PAD_CTL_PAD_DRAM_SDQS0
> +DATA 4  0x020e05b0 0x00000030  // IOMUXC_SW_PAD_CTL_PAD_DRAM_SDQS1
> +DATA 4  0x020e0524 0x00000030  // IOMUXC_SW_PAD_CTL_PAD_DRAM_SDQS2
> +DATA 4  0x020e051c 0x00000030  // IOMUXC_SW_PAD_CTL_PAD_DRAM_SDQS3
> +//DATA 4  0x020e0518 0x00000030  // IOMUXC_SW_PAD_CTL_PAD_DRAM_SDQS4
> +//DATA 4  0x020e050c 0x00000030  // IOMUXC_SW_PAD_CTL_PAD_DRAM_SDQS5
> +//DATA 4  0x020e05b8 0x00000030  // IOMUXC_SW_PAD_CTL_PAD_DRAM_SDQS6
> +//DATA 4  0x020e05c0 0x00000030  // IOMUXC_SW_PAD_CTL_PAD_DRAM_SDQS7

Better to remove unused lines.