[U-Boot] [PATCH] imx: i.mx6q: add the initial support for LogicPD i.MX6Q SOM

[Tom Rini]

On Wed, Mar 22, 2017 at 05:07:02PM -0500, Adam Ford wrote:

> Logic PD has an i.MX6Q system on module (SOM) with a development kit.
> This have been verified to boot the i.MX6Q version over either SD
> on the development kit or NAND built into the SOM.
> 
> Signed-off-by: Adam Ford <aford173 at gmail.com>
> 
> diff --git a/arch/arm/cpu/armv7/mx6/Kconfig b/arch/arm/cpu/armv7/mx6/Kconfig
> index 190e5c6..059d905 100644
> --- a/arch/arm/cpu/armv7/mx6/Kconfig
> +++ b/arch/arm/cpu/armv7/mx6/Kconfig
> @@ -367,6 +367,13 @@ config TARGET_ZC5601
>  	select DM
>  	select DM_THERMAL
>  
> +config TARGET_MX6LOGICPD
> +	bool "mx6logicpd"
> +	select BOARD_LATE_INIT
> +	select DM
> +	select DM_THERMAL
> +	select BOARD_EARLY_INIT_F

Please sort this as well.

[snip]
> +Currently there are three methods for booting mx6sabresd boards:
> diff --git a/board/logicpd/imx6/imx6logic.c b/board/logicpd/imx6/imx6logic.c
> new file mode 100644
> index 0000000..18ec9a1
> --- /dev/null
> +++ b/board/logicpd/imx6/imx6logic.c
> @@ -0,0 +1,364 @@
> +/*
> + * Copyright (C) 2017 Logic PD, Inc.
> + *
> + * Author: Adam Ford <aford173 at gmail.com>

... based on board/.../ since I assume you copied mx6sabresd here as
well :)

[snip]
> +int board_late_init(void)
> +{
> +#ifdef CONFIG_CMD_BMODE
> +	add_board_boot_modes(board_boot_modes);
> +#endif
> +#ifdef CONFIG_ENV_VARS_UBOOT_RUNTIME_CONFIG
> +	setenv("board_name", "imx6_logicpd");
> +
> +	if (is_mx6dqp()) {
> +		setenv("board_rev", "MX6QP");
> +		setenv("fdt_file", "imx6q-logicpd.dtb");
> +	}
> +	else if (is_mx6dq()) {
> +		setenv("board_rev", "MX6Q");
> +		setenv("fdt_file", "imx6q-logicpd.dtb");
> +	}
> +	else if (is_mx6sdl()) {
> +		setenv("board_rev", "MX6DL");
> +		setenv("fdt_file", "imx6sdl-logicpd.dtb");
> +	}
> +	else if (is_mx6solo()) {
> +		setenv("board_rev", "MX6SOLO");
> +		setenv("fdt_file", "imx6sdl-logicpd.dtb");
> +	}
> +#endif

Do all of these variations exist?

> diff --git a/include/configs/imx6_logic.h b/include/configs/imx6_logic.h
> new file mode 100644
> index 0000000..556cad2
> --- /dev/null
> +++ b/include/configs/imx6_logic.h
> @@ -0,0 +1,194 @@
> +/*
> + * Copyright (C) 2017 Logic PD, Inc.
> + *
> + * Configuration settings for the LogicPD i.MX6 SOM.
> + *
> + * SPDX-License-Identifier:    GPL-2.0+
> + */
> +
> +#ifndef __IMX6LOGIC_CONFIG_H
> +#define __IMX6LOGIC_CONFIG_H
> +
> +#define CONFIG_MACH_TYPE       3980

New board, we should not need MACH_TYPE and I bet that's not the "real"
one for your brand new board.

> +	"fdt_high=0xffffffff\0"   \
> +	"initrd_high=0xffffffff\0" \

I'm really really not a fan of disabling these relocations, please use
bootm_size to tell U-Boot where to make sure everything resides without
overlap.  Also, distro boot?

[snip]
> +# define MTDPARTS_DEFAULT	"mtdparts=gpmi-nand:4m(uboot)," \
> +					"1m(env),8m(kernel),1m(dtb),-(fs)"

Are you really sure all of these sizes are what you can live with for a
long long time?  That kernel size feels small.

Thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170322/8b61fdea/attachment.sig>