[U-Boot] board/BuR/common: incorrect check of dtb

Hannes Schmelzer hannes at schmelzer.or.at
Fri May 5 18:44:00 UTC 2017


On 05/05/2017 08:14 PM, Tom Rini wrote:
> On Fri, May 05, 2017 at 08:11:54PM +0200, Anatolij Gustschin wrote:
>> On Fri, 5 May 2017 12:38:06 -0400
>> Tom Rini trini at konsulko.com wrote:
>> ...
>>>>   	char *dtbname = getenv("dtb");
>>>>   	char *dtbdev = getenv("dtbdev");
>>>>   	char *dtppart = getenv("dtbpart");
>>>> -	if (!dtbdev || !dtbdev || !dtbname) {
>>>> +	if (!dtbdev || !dtbpart || !dtbname) {
>>>>   		printf("%s: <dtbdev>/<dtbpart>/<dtb> missing.\n", __func__);
>>>>   		return -1;
>>>>   	}
>>> This breaks some boards such as brppt1_mmc, which I agree doesn't make a
>>> lot of sense with just the above context, can you please test building
>>> 'BuR' via buildman?  Thanks!
>> dtbpart is wrong here, the defined variable is dtppart.
> Ah-ha!  Time to clean off the laptop screen...
Yeah, maybe we should also do some cosmetic cleanup on this with an 
extra patch.
This typo is here since the early days ;-)

Heinrich, could you do so?

cheers,
Hannes



More information about the U-Boot mailing list