[U-Boot] [PATCH 09/17] pcm058: Fix unused variable warnings

Stefano Babic sbabic at denx.de
Tue May 9 07:26:57 UTC 2017


On 09/05/2017 04:14, Tom Rini wrote:
> The variable nfc_pads is only referenced when CONFIG_CMD_NAND is set,
> add a gaurd.  The variable gpio_pads is never referenced, drop it.  The
> variable usdhc4_pads are only referenced when we do not have
> CONFIG_CMD_NAND set and we are not doing an SPL build, modify the
> existing guard.
> 
> Cc: Stefano Babic <sbabic at denx.de>
> Signed-off-by: Tom Rini <trini at konsulko.com>
> ---
>  board/phytec/pcm058/pcm058.c | 9 +++------
>  1 file changed, 3 insertions(+), 6 deletions(-)
> 
> diff --git a/board/phytec/pcm058/pcm058.c b/board/phytec/pcm058/pcm058.c
> index c3607daf4605..3dc8cbd6a50b 100644
> --- a/board/phytec/pcm058/pcm058.c
> +++ b/board/phytec/pcm058/pcm058.c
> @@ -108,6 +108,7 @@ static iomux_v3_cfg_t const ecspi1_pads[] = {
>  	MX6_PAD_EIM_D19__GPIO3_IO19 | MUX_PAD_CTRL(NO_PAD_CTRL),
>  };
>  
> +#ifdef CONFIG_CMD_NAND
>  /* NAND */
>  static iomux_v3_cfg_t const nfc_pads[] = {
>  	MX6_PAD_NANDF_CLE__NAND_CLE     | MUX_PAD_CTRL(NAND_PAD_CTRL),
> @@ -130,11 +131,7 @@ static iomux_v3_cfg_t const nfc_pads[] = {
>  	MX6_PAD_NANDF_D7__NAND_DATA07   | MUX_PAD_CTRL(NAND_PAD_CTRL),
>  	MX6_PAD_SD4_DAT0__NAND_DQS	| MUX_PAD_CTRL(NAND_PAD_CTRL),
>  };
> -
> -
> -/* GPIOS */
> -static iomux_v3_cfg_t const gpios_pads[] = {
> -};
> +#endif
>  
>  static struct i2c_pads_info i2c_pad_info2 = {
>  	.scl = {
> @@ -167,7 +164,7 @@ static iomux_v3_cfg_t const usdhc1_pads[] = {
>  	MX6_PAD_EIM_BCLK__GPIO6_IO31	| MUX_PAD_CTRL(NO_PAD_CTRL), /* CD */
>  };
>  
> -#ifndef CONFIG_CMD_NAND
> +#if !defined(CONFIG_CMD_NAND) && !defined(CONFIG_SPL_BUILD)
>  static iomux_v3_cfg_t const usdhc4_pads[] = {
>  	MX6_PAD_SD4_CLK__SD4_CLK	| MUX_PAD_CTRL(USDHC_PAD_CTRL),
>  	MX6_PAD_SD4_CMD__SD4_CMD	| MUX_PAD_CTRL(USDHC_PAD_CTRL),
> 

Reviewed-by: Stefano Babic <sbabic at denx.de>

Best regards,
Stefano

-- 
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================


More information about the U-Boot mailing list