[U-Boot] [PATCH v2 4/5] arm: socfpga: Move the FPGA driver header from arch/arm to include/

Marek Vasut marex at denx.de
Fri May 12 07:27:45 UTC 2017


On 05/12/2017 05:33 AM, Chee, Tien Fong wrote:
> On Kha, 2017-05-11 at 14:04 +0200, Marek Vasut wrote:
>> On 05/11/2017 11:25 AM, tien.fong.chee at intel.com wrote:
>>>
>>> From: Tien Fong Chee <tien.fong.chee at intel.com>
>>>
>>> Move arch/arm FPGA driver header to include/intel_socfpga which
>>> would be shared between arch platform drivers and FPGA drivers.
>> Doesn't this patchset only add support for arria10 FPGA ? If so, this
>> patch is pointless in the context of this patchset.
>>
> Arria10 FPGA header include fpga_manager.h as common header.There are
> other headers depend on above common header. So that means they are all
> related to each others. Hence this patch is needed to ensure all
> related restructure properly before adding Arria10 FPGA driver.

But that stuff can still be in arch/arm/mach-socfpga/include , why do
you move stuff into include/intel_fpga ?

>>>
>>> Signed-off-by: Tien Fong Chee <tien.fong.chee at intel.com>
>>> ---
>>>  arch/arm/mach-socfpga/reset_manager_arria10.c |  2 +-
>>>  arch/arm/mach-socfpga/reset_manager_gen5.c    |  5 +-
>>>  arch/arm/mach-socfpga/system_manager_gen5.c   |  2 +-
>>>  drivers/ddr/altera/sdram.c                    |  5 +-
>>>  drivers/fpga/socfpga.c                        |  5 +-
>>>  drivers/fpga/socfpga_gen5.c                   |  2 +-
>>>  include/intel_socfpga/fpga_manager.h          | 37 +++++++++++++++
>>>  include/intel_socfpga/fpga_manager_gen5.h     | 68
>>> +++++++++++++++++++++++++++
>>>  8 files changed, 116 insertions(+), 10 deletions(-)
>>>  create mode 100644 include/intel_socfpga/fpga_manager.h
>>>  create mode 100644 include/intel_socfpga/fpga_manager_gen5.h

[...]

-- 
Best regards,
Marek Vasut


More information about the U-Boot mailing list