[U-Boot] [Patch v3 2/2] armv8: ls1088: Enable SATA for ls1088

[Ashish Kumar]

Hello York, 

Please see inline.

Regards
Ashish

-----Original Message-----
From: York Sun 
Sent: Tuesday, October 31, 2017 8:37 PM
To: Ashish Kumar <ashish.kumar at nxp.com>; u-boot at lists.denx.de
Cc: Amrita Kumari <amrita.kumari at nxp.com>; Andy Tang <andy.tang at nxp.com>
Subject: Re: [Patch v3 2/2] armv8: ls1088: Enable SATA for ls1088

On 10/31/2017 02:55 AM, Ashish Kumar wrote:
> Signed-off-by: Ashish Kumar <Ashish.Kumar at nxp.com>
> Signed-off-by: Amrita Kumari <amrita.kumari at nxp.com>
> ---
> v2: Rebase to top
> v3: Consolidate defines in common file
> 
>  include/configs/ls1088a_common.h | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/include/configs/ls1088a_common.h 
> b/include/configs/ls1088a_common.h
> index fa058f7..9d59472 100644
> --- a/include/configs/ls1088a_common.h
> +++ b/include/configs/ls1088a_common.h
> @@ -148,6 +148,17 @@ unsigned long long get_qixis_addr(void);
>  /* Miscellaneous configurable options */
>  #define CONFIG_SYS_LOAD_ADDR	(CONFIG_SYS_DDR_SDRAM_BASE + 0x10000000)
>  
> +/* SATA */
> +#define CONFIG_LIBATA
> +#define CONFIG_SCSI_AHCI
> +#define CONFIG_SCSI_AHCI_PLAT
> +#define CONFIG_SYS_SATA1		AHCI_BASE_ADDR1
> +
> +#define CONFIG_SYS_SCSI_MAX_SCSI_ID	1
> +#define CONFIG_SYS_SCSI_MAX_LUN		1
> +#define CONFIG_SYS_SCSI_MAX_DEVICE	(CONFIG_SYS_SCSI_MAX_SCSI_ID * \
> +					CONFIG_SYS_SCSI_MAX_LUN)
> +
>  /* Physical Memory Map */
>  #define CONFIG_CHIP_SELECTS_PER_CTRL	4
>  
> 

I see you use "imply SCSI" in Kconfig, wouldn't it be better to put #ifdef to guard above macros so it may be easier to turn off SATA by menuconfig and/or defconfig if needed?
> You mean to add #ifdef CONFIG_SCSI here along with "imply SCSI" in Kconfig?


York