[U-Boot] [PATCH 1/4] arm64: ls1043ardb: Add sd_bootcmd for distro fallback in case of sdboot

[Mingkai Hu]

> -----Original Message-----
> From: York Sun
> Sent: Tuesday, October 31, 2017 2:45 AM
> To: Mingkai Hu <mingkai.hu at nxp.com>
> Cc: Shengzhou Liu <shengzhou.liu at nxp.com>; u-boot at lists.denx.de
> Subject: Re: [U-Boot] [PATCH 1/4] arm64: ls1043ardb: Add sd_bootcmd for
> distro fallback in case of sdboot
> 
> On 10/23/2017 01:53 PM, York Sun wrote:
> > On 09/14/2017 02:26 PM, York Sun wrote:
> >> On 08/30/2017 03:43 AM, Shengzhou Liu wrote:
> >>> Signed-off-by: Shengzhou Liu <Shengzhou.Liu at nxp.com>
> >>> ---
> >>>   include/configs/ls1043a_common.h | 11 ++++++++++-
> >>>   1 file changed, 10 insertions(+), 1 deletion(-)
> >>>
> >>> diff --git a/include/configs/ls1043a_common.h
> >>> b/include/configs/ls1043a_common.h
> >>> index f064d5c24a..976c031574 100644
> >>> --- a/include/configs/ls1043a_common.h
> >>> +++ b/include/configs/ls1043a_common.h
> >>> @@ -281,6 +281,8 @@
> >>>   	"fdt_addr_r=0x90000000\0"		\
> >>>   	"load_addr=0xa0000000\0"		\
> >>>   	"kernel_size=0x2800000\0"		\
> >>> +	"kernel_addr_sd=0x8000\0"		\
> >>> +	"kernel_size_sd=0x14000\0"		\
> >>>   	"console=ttyS0,115200\0"		\
> >>>   	"mtdparts=" MTDPARTS_DEFAULT "\0"	\
> >>>   	BOOTENV					\
> >>> @@ -318,12 +320,19 @@
> >>>   		"$kernel_addr $kernel_size && bootm
> $load_addr#$board\0" \
> >>>   	"nor_bootcmd=echo Trying load from nor..;"	\
> >>>   		"cp.b $kernel_addr $load_addr "	\
> >>> -		"$kernel_size && bootm $load_addr#$board\0"
> >>> +		"$kernel_size && bootm $load_addr#$board\0"	\
> >>> +	"sd_bootcmd=echo Trying load from SD ..;"	\
> >>> +		"mmcinfo; mmc read $load_addr "		\
> >>> +		"$kernel_addr_sd $kernel_size_sd ;"	\
> >>> +		" bootm $load_addr#$board\0"
> >>>
> >>
> >> Shouldn't you be using "&&" instead of ";" between commands?
> >>
> >
> > Shengzhou,
> >
> > Are you going to update the patches?
> 
> Mingkai,
> 
> Do you need this change for LS1043ARDB? Please respond to my comment if
> so. Otherwise, I will drop this set.
> 
> York

Hi York,

This will be needed in order to keep consistent with our LSDK.

Thanks,
Mingkai