[U-Boot] [PATCH] gpt: Use cache aligned buffers for gpt_h and gpt_e

Lukasz Majewski lukma at denx.de
Sun Nov 5 22:18:12 UTC 2017


On Fri, 27 Oct 2017 12:28:10 +0200
Lukasz Majewski <lukma at denx.de> wrote:

> Before this patch one could receive following errors when executing
> "gpt write" command on machine with cache enabled:
> 
> display5 factory > gpt write mmc ${mmcdev} ${partitions}
> Writing GPT:
> CACHE: Misaligned operation at range [4ef8f7f0, 4ef8f9f0]
> CACHE: Misaligned operation at range [4ef8f9f8, 4ef939f8]
> CACHE: Misaligned operation at range [4ef8f9f8, 4ef939f8]
> CACHE: Misaligned operation at range [4ef8f7f0, 4ef8f9f0]
> success!
> 
> To alleviate this problem - the calloc()s have been replaced with
> malloc_cache_aligned() and memset().
> 
> After those changes the buffers are properly aligned (with both start
> address and size) to SoC cache line.

Any feedback?

This patch seems like a good candidate for v2017.11 (as a fix to gpt
command)

Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20171105/97fe067c/attachment.sig>


More information about the U-Boot mailing list