[U-Boot] [PATCH 1/2] sunxi: binman: Add U-Boot binary size check

[Maxime Ripard]

On Fri, Nov 03, 2017 at 06:01:20PM +0100, Frank Kunz wrote:
> Am Freitag, 3. November 2017, 09:42:44 CET schrieb Maxime Ripard:
> > Hi Frank,
> > 
> > On Thu, Nov 02, 2017 at 04:53:54PM +0100, Frank Kunz wrote:
> > > Am Donnerstag, 19. Oktober 2017, 16:04:18 CET schrieb Maxime Ripard:
> > > > The U-boot binary may trip over its actual allocated size in the
> > > > storage.
> > > > In such a case, the environment will not be readable anymore (because
> > > > corrupted when the new image was flashed), and any attempt at using
> > > > saveenv
> > > > to reconstruct the environment will result in a corrupted U-boot binary.
> > > > 
> > > > Signed-off-by: Maxime Ripard <maxime.ripard at free-electrons.com>
> > > > ---
> > > > 
> > > >  arch/arm/dts/sunxi-u-boot.dtsi | 11 +++++++++++
> > > >  1 file changed, 11 insertions(+)
> > > 
> > > I found that this patch causes the sunxi-fel tool to fail with:
> > > 
> > > sunxi-fel uboot u-boot-sunxi-with-spl.bin
> > > U-Boot image data size mismatch: expected 516032, got 389212
> > > 
> > > Is there a patch for the sunxi tools missing?
> > 
> > No, because no one reported it so far.
> > 
> > Can you test with:
> > http://code.bulix.org/mb0ic7-221765?raw
> > 
> 
> That works.
> 
> Tested-by: Frank Kunz <mailinglists at kunz-im-inter.net>

I created a pull request for sunxi-tools to fix the issue. Thanks for
the test, and sorry for the bug.

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20171106/c7466c1b/attachment.sig>