[U-Boot] [PATCH] sunxi: a64: Add verified-boot support

[Jagan Teki]

On Wed, Nov 8, 2017 at 4:25 PM, Maxime Ripard
<maxime.ripard at free-electrons.com> wrote:
> Hi,
>
> On Wed, Nov 08, 2017 at 12:40:05AM +0530, Jagan Teki wrote:
>> Enable verified-boot support for sunxi a64, tested the
>> same in orangepi boards.
>>
>> Signed-off-by: Jagan Teki <jagan at amarulasolutions.com>
>
> How was it tested? Can you write some documentation for it?

Thought of adding the same, will add in next version.

>
>> ---
>>  arch/arm/mach-sunxi/Kconfig    | 2 ++
>>  include/configs/sunxi-common.h | 2 ++
>>  2 files changed, 4 insertions(+)
>>
>> diff --git a/arch/arm/mach-sunxi/Kconfig b/arch/arm/mach-sunxi/Kconfig
>> index 09cfec6..cf6b264 100644
>> --- a/arch/arm/mach-sunxi/Kconfig
>> +++ b/arch/arm/mach-sunxi/Kconfig
>> @@ -178,6 +178,8 @@ config MACH_SUN50I
>>       select SUNXI_DRAM_DW
>>       select SUNXI_DRAM_DW_32BIT
>>       select FIT
>> +     select FIT_SIGNATURE
>
> I'd rather not select it, given the recent issues with the binary
> size, and the fact that this has been tested only on one, quite
> recent, SoC so far.
>
> How about an imply? or a default y?
>
>> +     select FIT_VERBOSE
>
> Why do you need this?

I usually used this(even with other SOC) for debug messages if FIT
image fail to load.

>
>>       select SPL_LOAD_FIT
>>
>>  config MACH_SUN50I_H5
>> diff --git a/include/configs/sunxi-common.h b/include/configs/sunxi-common.h
>> index 4207398..921eb4f 100644
>> --- a/include/configs/sunxi-common.h
>> +++ b/include/configs/sunxi-common.h
>> @@ -34,6 +34,8 @@
>>
>>  #ifdef CONFIG_ARM64
>>  #define CONFIG_BUILD_TARGET "u-boot.itb"
>> +/* Extend size of kernel image for uncompression */
>> +#define CONFIG_SYS_BOOTM_LEN (60 * 1024 * 1024)
>
> I thought the arm64 kernels were uncompressed?

I've tested with Image.gz

>
> That should probably be in a separate patch anyway.

Yes, will send in it another patch.

thanks!
-- 
Jagan Teki
Free Software Engineer | www.openedev.com
U-Boot, Linux | Upstream Maintainer
Hyderabad, India.