[U-Boot] [U-Boot, 2/3] rockchip: doc: update U-Boot location info

[Jagan Teki]

On Fri, Nov 10, 2017 at 4:48 PM, Dr. Philipp Tomsich
<philipp.tomsich at theobroma-systems.com> wrote:
> Jagan,
>
>> On 10 Nov 2017, at 12:12, Jagan Teki <jagan at amarulasolutions.com> wrote:
>>
>> On Fri, Nov 10, 2017 at 3:53 PM, Dr. Philipp Tomsich
>> <philipp.tomsich at theobroma-systems.com> wrote:
>>> Kever,
>>>
>>>> On 10 Nov 2017, at 08:24, Goldschmidt Simon <sgoldschmidt at de.pepperl-fuchs.com> wrote:
>>>>
>>>>>> Update rockchip U-Boot location to 0x4000/16384.
>>>
>>> At least the location given in the commit message is consistent:
>>>        (gdb) p 0x4000
>>>        $1 = 16384
>>>
>>>>>> Signed-off-by: Kever Yang <kever.yang at rock-chips.com>
>>>>>> Acked-by: Philipp Tomsich <philipp.tomsich at theobroma-systems.com>
>>>>>> Reviewed-by: Philipp Tomsich <philipp.tomsich at theobroma-systems.com>
>>>>>> ---
>>>>>>
>>>>>> doc/README.rockchip | 6 +++---
>>>>>> 1 file changed, 3 insertions(+), 3 deletions(-)
>>>>>>
>>>>>
>>>>> Applied to u-boot-rockchip, thanks!
>>>>
>>>> I just found this commit has calculated the size wrong. 16384 blocks should be 8MB, not 4MB.
>>>
>>> Could you take a look at this and let us know if this should be changed?
>>> And if it needs a change (and you want it in Monday’s release): please submit a
>>> patch and I’ll try to generate a PR to Tom over the weekend…
>>
>> This even require some README.rockchip and falcon offset changes,
>> Sorry I really don't understand why the new features been added for
>> release tree.
>
> This is not a new feature, but merely a configuration change.
> Plus, it ensures consistency with the (legacy) vendor U-Boot.

AFAIK, global config options sometimes new changes I've seen the
series in ML on 02/11 which is crossed MW. ie reason I've commented.

> Note that worked fine my smoke tests, as we have the offsets configured in the
> DTS for our boards and don’t rely on platform/chipset defaults (which will never
> be right for all use-cases anyway)…

OK.

thanks!
-- 
Jagan Teki
Free Software Engineer | www.openedev.com
U-Boot, Linux | Upstream Maintainer
Hyderabad, India.