[U-Boot] [PATCH] dm: core: Correct address cast in dev_read_addr_ptr()

sjg at google.com sjg at google.com
Fri Nov 17 15:41:48 UTC 2017


On Sun, Oct 01, 2017 at 12:31:21AM +0200, Dr. Philipp Tomsich wrote:
>
> > On 30 Sep 2017, at 22:32, Tom Rini <trini at konsulko.com> wrote:
> >
> > On Sat, Sep 30, 2017 at 06:08:02PM +0200, Dr. Philipp Tomsich wrote:
> >> Simon,
> >>
> >>> On 28 Sep 2017, at 18:14, Dr. Philipp Tomsich <philipp.tomsich at theobroma-systems.com> wrote:
> >>>
> >>>
> >>>> On 28 Sep 2017, at 14:35, Simon Glass <sjg at chromium.org> wrote:
> >>>>
> >>>> This currently causes a warning in sandbox and will not do the right
> >>>> thing:
> >>>>
> >>>> drivers/core/read.c: In function ‘dev_read_addr_ptr’:
> >>>> drivers/core/read.c:64:44: warning: cast to pointer from integer of
> >>>> 	different size [-Wint-to-pointer-cast]
> >>>> return (addr == FDT_ADDR_T_NONE) ? NULL : (void *)addr;
> >>>>
> >>>> Use map_sysmem() which is the correct way to convert an address to a
> >>>> pointer.
> >>>>
> >>>> Fixes: c131c8bca8 (dm: core: add dev_read_addr_ptr())
> >>>> Signed-off-by: Simon Glass <sjg at chromium.org>
> >>>
> >>> Reviewed-by: Philipp Tomsich <philipp.tomsich at theobroma-systems.com>
> >>
> >>
> >> Acked-by: Philipp Tomsich <philipp.tomsich at theobroma-systems.com>
> >>
> >> I’ll pull this one in through u-boot-rockchip now, as Tom raised it as a build
> >> issue against my last pull-request.
> >
> > Well, that's for the minor existing warning.  The big problem is the
> > build failures :)
>
> I already backed Jagan’s change to mach-tegra/cache.c out (missed that
> during my review and testing) and this is already running on Travis.
>
> I understood you that I should also address those warnings related to
> the Rockchip code?  If not, I’d rather have this one go through the -dm
> tree…

The DM warning fix can come via Simon's tree, thanks!

-- 
Tom

Applied to u-boot-dm thanks!


More information about the U-Boot mailing list