[U-Boot] [PATCH v2 18/18] efi_loader: helper function to add EFI object to list

[Heinrich Schuchardt]

On 11/17/2017 03:07 PM, Simon Glass wrote:
> On 12 November 2017 at 07:02, Heinrich Schuchardt <xypron.glpk at gmx.de> wrote:
>> To avoid duplicate coding provide a helper function that
>> initializes an EFI object and adds it to the EFI object
>> list.
>>
>> efi_exit() is the only place where we dereference a handle
> 
> de-reference?

Google spits out zillions of results for writing it without hyphen 
including online dictionaries.

Regards

Heinrich

> 
>> to obtain a protocol interface. Add a comment to the function.
>>
>> Suggested-by: Alexander Graf <agraf at suse.de>
>> Signed-off-by: Heinrich Schuchardt <xypron.glpk at gmx.de>
>> ---
>> v2
>>          new patch
>> ---
>>   include/efi_loader.h          |  2 ++
>>   lib/efi_loader/efi_boottime.c | 39 ++++++++++++++++++++++++++++++++-------
>>   lib/efi_loader/efi_disk.c     |  4 +---
>>   lib/efi_loader/efi_gop.c      |  4 +---
>>   lib/efi_loader/efi_net.c      |  4 +---
>>   5 files changed, 37 insertions(+), 16 deletions(-)
> 
> Reviewed-by: Simon Glass <sjg at chromium.org>
>