[U-Boot] [U-Boot,2/2] rk3288: tinker: Add falcon mode support

[Philipp Tomsich]

On Sat, 4 Nov 2017, Jagan Teki wrote:

> Add Falcon mode support in tinker rk3288 board.
>
> Signed-off-by: Jagan Teki <jagan at amarulasolutions.com>
> Acked-by: Philipp Tomsich <philipp.tomsich at theobroma-systems.com>

Reviewed-by: Philipp Tomsich <philipp.tomsich at theobroma-systems.com>

See below for requested changes.

> ---
> Note:
> This patch[1] need to work falcon
>
> [1] https://patchwork.ozlabs.org/patch/833821/
>
> board/rockchip/tinker_rk3288/tinker-rk3288.c | 13 +++++++++++++
> include/configs/tinker_rk3288.h              | 16 ++++++++++++++++
> 2 files changed, 29 insertions(+)
>
> diff --git a/board/rockchip/tinker_rk3288/tinker-rk3288.c b/board/rockchip/tinker_rk3288/tinker-rk3288.c
> index 790a921..48e0c41 100644
> --- a/board/rockchip/tinker_rk3288/tinker-rk3288.c
> +++ b/board/rockchip/tinker_rk3288/tinker-rk3288.c
> @@ -9,6 +9,19 @@
> #include <i2c_eeprom.h>
> #include <netdev.h>
>
> +#ifndef CONFIG_TPL_BUILD
> +#include <spl.h>

Please keep this with the include statements above and make the #include 
unconditional.

> +
> +int spl_start_uboot(void)
> +{
> +        /* break into full u-boot on 'c' */
> +        if (serial_tstc() && serial_getc() == 'c')
> +                return 1;
> +
> +        return 0;
> +}
> +#endif
> +
> static int get_ethaddr_from_eeprom(u8 *addr)
> {
> 	int ret;
> diff --git a/include/configs/tinker_rk3288.h b/include/configs/tinker_rk3288.h
> index 58eea3c..6d4f271 100644
> --- a/include/configs/tinker_rk3288.h
> +++ b/include/configs/tinker_rk3288.h
> @@ -20,4 +20,20 @@
>
> #define CONFIG_SYS_MMC_ENV_DEV 1
>
> +#ifndef CONFIG_TPL_BUILD
> +#define CONFIG_SPL_OS_BOOT
> +
> +/* Falcon Mode */
> +#define CONFIG_SPL_FS_LOAD_ARGS_NAME	"args"
> +#define CONFIG_SPL_FS_LOAD_KERNEL_NAME	"uImage"
> +#define CONFIG_CMD_SPL
> +#define CONFIG_SYS_SPL_ARGS_ADDR	0x0ffe5000
> +#define CONFIG_CMD_SPL_WRITE_SIZE      (128 * SZ_1K)
> +
> +/* Falcon Mode - MMC support: args at 1MB kernel at 2MB */
> +#define CONFIG_SYS_MMCSD_RAW_MODE_ARGS_SECTOR  0x800   /* 1MB */
> +#define CONFIG_SYS_MMCSD_RAW_MODE_ARGS_SECTORS (CONFIG_CMD_SPL_WRITE_SIZE / 512)
> +#define CONFIG_SYS_MMCSD_RAW_MODE_KERNEL_SECTOR        0x1000  /* 2MB */
> +#endif
> +
> #endif
>