[U-Boot] [PATCH 1/5] dm: mmc: updated mmc_of_parse() to not fail because of an invalid bus-width

[Simon Glass]

Hi Jean-Jacques,


On 21 November 2017 at 08:13, Jean-Jacques Hiblot <jjhiblot at ti.com> wrote:
> Instead of failing, the driver uses the default: 1-bit bus width.
>
> Signed-off-by: Jean-Jacques Hiblot <jjhiblot at ti.com>
> ---
>  drivers/mmc/mmc-uclass.c | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/mmc/mmc-uclass.c b/drivers/mmc/mmc-uclass.c
> index e30cde7..48fafce 100644
> --- a/drivers/mmc/mmc-uclass.c
> +++ b/drivers/mmc/mmc-uclass.c
> @@ -137,9 +137,10 @@ int mmc_of_parse(const void *fdt, int node, struct mmc_config *cfg)

Can you please add a function comment for this function in the header?

Also if you have time, this function should be converted to use live
tree - dev_read...() etc.

>                 cfg->host_caps |= MMC_MODE_1BIT;
>                 break;
>         default:
> -               printf("error: %s invalid bus-width property %d\n",
> -                      fdt_get_name(fdt, node, NULL), val);
> -               return -ENOENT;
> +               debug("warning: %s invalid bus-width property. using 1-bit\n",
> +                     fdt_get_name(fdt, node, NULL));
> +               cfg->host_caps |= MMC_MODE_1BIT;
> +               break;
>         }
>
>         cfg->f_max = fdtdec_get_int(fdt, node, "max-frequency", 52000000);
> --
> 1.9.1
>

Regards,
Simon