[U-Boot] [PATCH 1/1] vsprintf.c: add EFI device path printing

Wolfgang Denk wd at denx.de
Sun Nov 26 13:39:42 UTC 2017


Dear Heinrich,

In message <55e69128-b30c-78af-7e96-3aba873dfd73 at gmx.de> you wrote:
>
> to cut it short, would you prefer
> 
> https://patchwork.ozlabs.org/patch/840912/
> 
> or
> 
> https://github.com/xypron/u-boot-odroid-c2/blob/qemu-x86_64/patch/0001-vsprintf.c-add-EFI-device-path-printing.patch

Urgh.  I really hate such external references.

IIUC, then [2] has as only difference an additional early return in
printf().  The only effect of this is to skip the
"puts(printbuffer);".

I can't say if this is worth the effort.  In any case, you introduce
inconsistent behaviour here.  If you do it in printf(), it should
(at least) also be done in vprintf() [and probably one should check
the *snprintf() functions, too].

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Drawing on my fine command of language, I said nothing.


More information about the U-Boot mailing list