[U-Boot] [PATCH v2 1/4] dm: mmc: update mmc_of_parse()
Jean-Jacques Hiblot
jjhiblot at ti.com
Mon Nov 27 09:59:03 UTC 2017
* convert to livetree API
* don't fail because of an invalid bus-width, instead default to 1-bit.
* recognize 1.2v DDR and 1.2v HS200 flags
Signed-off-by: Jean-Jacques Hiblot <jjhiblot at ti.com>
---
changes since v1:
* convert to livetree
* squashed all change to mmc_of_parse into this single commit
* Add a descriptive comment fo mmc_of_parse in the header
drivers/mmc/mmc-uclass.c | 37 ++++++++++++++++++++++---------------
include/mmc.h | 11 ++++++++++-
2 files changed, 32 insertions(+), 16 deletions(-)
diff --git a/drivers/mmc/mmc-uclass.c b/drivers/mmc/mmc-uclass.c
index e30cde7..f117923 100644
--- a/drivers/mmc/mmc-uclass.c
+++ b/drivers/mmc/mmc-uclass.c
@@ -10,6 +10,7 @@
#include <dm.h>
#include <dm/device-internal.h>
#include <dm/lists.h>
+#include <dm/ofnode.h>
#include <dm/root.h>
#include "mmc_private.h"
@@ -120,11 +121,12 @@ int mmc_execute_tuning(struct mmc *mmc, uint opcode)
return dm_mmc_execute_tuning(mmc->dev, opcode);
}
-int mmc_of_parse(const void *fdt, int node, struct mmc_config *cfg)
+int mmc_of_parse(struct udevice *dev, struct mmc_config *cfg)
{
int val;
+ ofnode ref = dev_ofnode(dev);
- val = fdtdec_get_int(fdt, node, "bus-width", 1);
+ val = ofnode_read_u32_default(ref, "bus-width", 1);
switch (val) {
case 0x8:
@@ -137,30 +139,35 @@ int mmc_of_parse(const void *fdt, int node, struct mmc_config *cfg)
cfg->host_caps |= MMC_MODE_1BIT;
break;
default:
- printf("error: %s invalid bus-width property %d\n",
- fdt_get_name(fdt, node, NULL), val);
- return -ENOENT;
+ debug("warning: %s invalid bus-width property. using 1-bit\n",
+ ofnode_get_name(ref));
+ cfg->host_caps |= MMC_MODE_1BIT;
+ break;
}
- cfg->f_max = fdtdec_get_int(fdt, node, "max-frequency", 52000000);
+ cfg->f_max = ofnode_read_u32_default(ref, "max-frequency", 52000000);
- if (fdtdec_get_bool(fdt, node, "cap-sd-highspeed"))
+ if (ofnode_read_bool(ref, "cap-sd-highspeed"))
cfg->host_caps |= MMC_CAP(SD_HS);
- if (fdtdec_get_bool(fdt, node, "cap-mmc-highspeed"))
+ if (ofnode_read_bool(ref, "cap-mmc-highspeed"))
cfg->host_caps |= MMC_CAP(MMC_HS);
- if (fdtdec_get_bool(fdt, node, "sd-uhs-sdr12"))
+ if (ofnode_read_bool(ref, "sd-uhs-sdr12"))
cfg->host_caps |= MMC_CAP(UHS_SDR12);
- if (fdtdec_get_bool(fdt, node, "sd-uhs-sdr25"))
+ if (ofnode_read_bool(ref, "sd-uhs-sdr25"))
cfg->host_caps |= MMC_CAP(UHS_SDR25);
- if (fdtdec_get_bool(fdt, node, "sd-uhs-sdr50"))
+ if (ofnode_read_bool(ref, "sd-uhs-sdr50"))
cfg->host_caps |= MMC_CAP(UHS_SDR50);
- if (fdtdec_get_bool(fdt, node, "sd-uhs-sdr104"))
+ if (ofnode_read_bool(ref, "sd-uhs-sdr104"))
cfg->host_caps |= MMC_CAP(UHS_SDR104);
- if (fdtdec_get_bool(fdt, node, "sd-uhs-ddr50"))
+ if (ofnode_read_bool(ref, "sd-uhs-ddr50"))
cfg->host_caps |= MMC_CAP(UHS_DDR50);
- if (fdtdec_get_bool(fdt, node, "mmc-ddr-1_8v"))
+ if (ofnode_read_bool(ref, "mmc-ddr-1_8v"))
cfg->host_caps |= MMC_CAP(MMC_DDR_52);
- if (fdtdec_get_bool(fdt, node, "mmc-hs200-1_8v"))
+ if (ofnode_read_bool(ref, "mmc-ddr-1_2v"))
+ cfg->host_caps |= MMC_CAP(MMC_DDR_52);
+ if (ofnode_read_bool(ref, "mmc-hs200-1_8v"))
+ cfg->host_caps |= MMC_CAP(MMC_HS_200);
+ if (ofnode_read_bool(ref, "mmc-hs200-1_2v"))
cfg->host_caps |= MMC_CAP(MMC_HS_200);
return 0;
diff --git a/include/mmc.h b/include/mmc.h
index 6230a32..e3f777f 100644
--- a/include/mmc.h
+++ b/include/mmc.h
@@ -651,7 +651,16 @@ int mmc_unbind(struct udevice *dev);
int mmc_initialize(bd_t *bis);
int mmc_init(struct mmc *mmc);
int mmc_send_tuning(struct mmc *mmc, u32 opcode, int *cmd_error);
-int mmc_of_parse(const void *fdt, int node, struct mmc_config *cfg);
+
+/**
+ * mmc_of_parse() - Parse the device tree to get the capabilities of the host
+ *
+ * @dev: MMC device
+ * @cfg: MMC configuration
+ * @return 0 if OK, -ve on error
+ */
+int mmc_of_parse(struct udevice *dev, struct mmc_config *cfg);
+
int mmc_read(struct mmc *mmc, u64 src, uchar *dst, int size);
/**
--
1.9.1
More information about the U-Boot
mailing list