[U-Boot] [PATCH 4/5] test/py: Allow any unit test suite to be found

Stephen Warren swarren at wwwdotorg.org
Mon Nov 27 18:08:23 UTC 2017


On 11/25/2017 11:57 AM, Simon Glass wrote:
> The u-boot.sym file is scanned to find unit test suites for execution. At
> present it only finds those whose names start with 'dm' or 'env'. This
> code is buried in the bowels of the test code so when adding a new suite
> it is not easy to discover why it is ignored by the test framework.
> 
> There seems to be no need to make this restriction. Drop it.

Acked-by: Stephen Warren <swarren at nvidia.com>

> diff --git a/test/py/conftest.py b/test/py/conftest.py

> -re_ut_test_list = re.compile(r'_u_boot_list_2_(dm|env)_test_2_\1_test_(.*)\s*$')
> +re_ut_test_list = re.compile(r'_u_boot_list_2_(.*)_test_2_\1_test_(.*)\s*$')

I think I made this regex restrictive to avoid accidentally matching 
lists (symbols) with "test" in the name that weren't known unit tests. 
Or maybe there were some unit tests that didn't work yet when I wrote 
it? If we're confident that won't happen, this change seems fine. If we 
do have a problem in the future, I guess we could just rename the symbol 
to s/test/unit_test/ or something to make matching more explicit.


More information about the U-Boot mailing list