[U-Boot] [PATCH v2 1/4] dm: mmc: update mmc_of_parse()

Jean-Jacques Hiblot jjhiblot at ti.com
Tue Nov 28 09:17:29 UTC 2017



On 27/11/2017 18:13, Simon Glass wrote:
> Hi Jean-Jacques,
>
> On 27 November 2017 at 02:59, Jean-Jacques Hiblot <jjhiblot at ti.com> wrote:
>> * convert to livetree API
>> * don't fail because of an invalid bus-width, instead default to 1-bit.
>> * recognize 1.2v DDR and 1.2v HS200 flags
>>
>> Signed-off-by: Jean-Jacques Hiblot <jjhiblot at ti.com>
>> ---
>> changes since v1:
>> * convert to livetree
>> * squashed all change to mmc_of_parse into this single commit
>> * Add a descriptive comment fo mmc_of_parse in the header
>>
>>   drivers/mmc/mmc-uclass.c | 37 ++++++++++++++++++++++---------------
>>   include/mmc.h            | 11 ++++++++++-
>>   2 files changed, 32 insertions(+), 16 deletions(-)
>>
>> diff --git a/drivers/mmc/mmc-uclass.c b/drivers/mmc/mmc-uclass.c
>> index e30cde7..f117923 100644
>> --- a/drivers/mmc/mmc-uclass.c
>> +++ b/drivers/mmc/mmc-uclass.c
>> @@ -10,6 +10,7 @@
>>   #include <dm.h>
>>   #include <dm/device-internal.h>
>>   #include <dm/lists.h>
>> +#include <dm/ofnode.h>
>>   #include <dm/root.h>
>>   #include "mmc_private.h"
>>
>> @@ -120,11 +121,12 @@ int mmc_execute_tuning(struct mmc *mmc, uint opcode)
>>          return dm_mmc_execute_tuning(mmc->dev, opcode);
>>   }
>>
>> -int mmc_of_parse(const void *fdt, int node, struct mmc_config *cfg)
>> +int mmc_of_parse(struct udevice *dev, struct mmc_config *cfg)
>>   {
>>          int val;
>> +       ofnode ref = dev_ofnode(dev);
> Do you need this? I think you can just use dev_read_...() below
> instead of ofnode_...() ?
Sure. I'll send the v3 shortly
>
> Regards,
> Simon
>



More information about the U-Boot mailing list