[U-Boot] [PATCH] net: zynq_gem: Dont enable SGMII and PCS selection

Michal Simek michal.simek at xilinx.com
Wed Nov 29 12:12:25 UTC 2017


On 23.11.2017 08:26, Siva Durga Prasad Paladugu wrote:
> Dont enable SGMII and PCS selection if internal PCS/PMA
> is not used, by getting the info about internal/external
> PCS/PMA usage from dt property "is-internal-phy".
> 
> Signed-off-by: Siva Durga Prasad Paladugu <sivadur at xilinx.com>
> ---
>  drivers/net/zynq_gem.c | 11 ++++++++++-
>  1 file changed, 10 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/zynq_gem.c b/drivers/net/zynq_gem.c
> index f6bbcdc..1dfd631 100644
> --- a/drivers/net/zynq_gem.c
> +++ b/drivers/net/zynq_gem.c
> @@ -182,6 +182,7 @@ struct zynq_gem_priv {
>  	int phy_of_handle;
>  	struct mii_dev *bus;
>  	struct clk clk;
> +	bool int_pcs;
>  };
>  
>  static u32 phy_setup_op(struct zynq_gem_priv *priv, u32 phy_addr, u32 regnum,
> @@ -425,7 +426,12 @@ static int zynq_gem_init(struct udevice *dev)
>  
>  	nwconfig = ZYNQ_GEM_NWCFG_INIT;
>  
> -	if (priv->interface == PHY_INTERFACE_MODE_SGMII) {
> +	/*
> +	 * Set SGMII enable PCS selection only if internal PCS/PMA
> +	 * core is used and interface is SGMII.
> +	 */
> +	if (priv->interface == PHY_INTERFACE_MODE_SGMII &&
> +	    priv->int_pcs) {
>  		nwconfig |= ZYNQ_GEM_NWCFG_SGMII_ENBL |
>  			    ZYNQ_GEM_NWCFG_PCS_SEL;
>  #ifdef CONFIG_ARM64
> @@ -697,6 +703,9 @@ static int zynq_gem_ofdata_to_platdata(struct udevice *dev)
>  	}
>  	priv->interface = pdata->phy_interface;
>  
> +	priv->int_pcs = fdtdec_get_bool(gd->fdt_blob, node,
> +					"is-internal-pcspma");
> +
>  	printf("ZYNQ GEM: %lx, phyaddr %x, interface %s\n", (ulong)priv->iobase,
>  	       priv->phyaddr, phy_string_for_interface(priv->interface));
>  
> 

Applied.

Thanks,
Michal


More information about the U-Boot mailing list