[U-Boot] [GIT PULL v2] u-boot-sunxi/master

[Tom Rini]

On Mon, Oct 02, 2017 at 10:44:31PM +0200, Maxime Ripard wrote:
> Hi Tom,
> 
> On Fri, Sep 29, 2017 at 12:52:47PM +0000, Tom Rini wrote:
> > On Fri, Sep 29, 2017 at 02:37:55PM +0200, Maxime Ripard wrote:
> > > Hi,
> > > 
> > > On Thu, Sep 28, 2017 at 01:02:58PM +0000, Tom Rini wrote:
> > > > On Thu, Sep 28, 2017 at 11:12:55AM +0200, Maxime Ripard wrote:
> > > > 
> > > > > Hi Tom,
> > > > > 
> > > > > Here is the second version of the pull request sent yesterday. It
> > > > > shouldn't show the config warnings anymore.
> > > > > 
> > > > > Thanks!
> > > > > Maxime
> > > > > 
> > > > > The following changes since commit 6e9b109aa9bcdd094e77da9fb03de8b44da8eb9d:
> > > > > 
> > > > >   Merge git://git.denx.de/u-boot-usb (2017-09-27 09:39:48 -0400)
> > > > > 
> > > > > are available in the git repository at:
> > > > > 
> > > > >   git://git.denx.de/u-boot-sunxi master
> > > > > 
> > > > > for you to fetch changes up to 6a191c5ef1294de8c09a3c4539b76a3d9fa60036:
> > > > > 
> > > > >   sunxi: usb_phy: invert the USB phy_ctl condition (2017-09-28 10:44:12 +0200)
> > > > > 
> > > > 
> > > > OK, there's still some problems.  As a rule, you should at least run
> > > > 'make tests' before posting and that shows:
> > > > +make O=/home/trini/work/u-boot/u-boot/build-sandbox -s -j8
> > > > ../drivers/core/read.c: In function ‘dev_read_addr_ptr’:
> > > > ../drivers/core/read.c:64:44: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
> > > >   return (addr == FDT_ADDR_T_NONE) ? NULL : (void *)addr;
> > > 
> > > This one is in the current master.
> > > 
> > > > ../lib/uuid.c: In function ‘gen_rand_uuid’:
> > > > ../lib/uuid.c:246:2: warning: implicit declaration of function ‘clrsetbits_be16’ [-Wimplicit-function-declaration]
> > > >   clrsetbits_be16(&uuid.time_hi_and_version,
> > > >   ^
> > > > ../lib/uuid.c:250:2: warning: implicit declaration of function ‘clrsetbits_8’ [-Wimplicit-function-declaration]
> > > >   clrsetbits_8(&uuid.clock_seq_hi_and_reserved,
> > > >   ^
> > > > lib/built-in.o: In function `gen_rand_uuid':
> > > > /home/trini/work/u-boot/u-boot/build-sandbox/../lib/uuid.c:246: undefined reference to `clrsetbits_be16'
> > > > /home/trini/work/u-boot/u-boot/build-sandbox/../lib/uuid.c:250: undefined reference to `clrsetbits_8'
> > > > collect2: error: ld returned 1 exit status
> > > > make[2]: *** [u-boot] Error 1
> > > > make[1]: *** [sub-make] Error 2
> > > 
> > > And these two are only seen on the sandbox, since arch/sandbox doesn't
> > > define the clrsetbits. How am I supposed to fix that?
> > 
> > We can't bring in patches that break other architectures.  In this case,
> > it doesn't look too bad to grab the macros from ARM and slightly adapt,
> > so I'll post a patch in a moment you can grab.
> 
> So I've set up travis-ci, and just built that branch with a couple of
> fixes and the patch for the sandbox io accessors I sent a bit earlier.
> 
> It has passed, so I guess we're good to go.
> 
> Do you want me to pick up the sandbox patch and send you the PR, or do
> you want to apply it yourself?
> 
> Sorry for the mess...

No worries.  Go ahead and grab the patch and send the new PR, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20171002/4126365e/attachment.sig>