[U-Boot] [U-Boot, v2, 1/1] kconfiglib: update with 'imply' support

Ulf Magnusson ulfalizer at gmail.com
Mon Oct 2 22:05:19 UTC 2017


On Fri, Sep 29, 2017 at 10:25 PM, Tom Rini <trini at konsulko.com> wrote:
> On Tue, Sep 19, 2017 at 12:52:55PM +0200, Ulf Magnusson wrote:
>
>> Corresponds to 375506d (File writing nit) from upstream
>> (https://github.com/ulfalizer/Kconfiglib).
>>
>> Adds proper 'imply' support and fixes a few minor issues, one of which
>> previously triggered the following weird warning:
>>
>>   configs/taurus_defconfig: /tmp/tmpisI45S:6: warning: assignment to SPL_LDSCRIPT changes mode of containing choice from "arch/$(ARCH)/cpu/u-boot-spl.lds" to "y"
>>
>> The change in 8639f69 (genconfig.py: Print defconfig next to warnings)
>> was reapplied.
>>
>> tools/moveconfig.py previously depended on a hack that merged 'select's
>> with 'imply's. It was modified to look at the union of
>> Symbol.get_selected_symbols() and Symbol.get_implied_symbols(), which
>> should give the same behavior.
>>
>> tools/genboardscfg.py was verified to produce identical board.cfg's
>> before and after the change.
>>
>> Signed-off-by: Ulf Magnusson <ulfalizer at gmail.com>
>
> Applied to u-boot/master, thanks!
>
> --
> Tom

For future reference, Kconfiglib is now available on PyPI and can be
installed via e.g. 'pip' (see the updated README at
https://github.com/ulfalizer/Kconfiglib).

Maybe the custom patch in 8639f69a (genconfig.py: Print defconfig next
to warnings) could be removed if stderr is temporarily redirected to a
string (https://stackoverflow.com/questions/1218933/can-i-redirect-the-stdout-in-python-into-some-sort-of-string-buffer).
I was thinking of adding an optional list argument to some functions
that would receive the warning strings if provided, but I'm not sure
if it's worth it. Would want them printed directly by default at
least, because otherwise people will miss them.

Cheers,
Ulf


More information about the U-Boot mailing list