[U-Boot] [PATCH v3 06/20] common: Generic firmware loader for file system

[Marek Vasut]

On 10/16/2017 04:08 PM, Dinh Nguyen wrote:
> 
> 
> On 10/13/2017 03:08 AM, tien.fong.chee at intel.com wrote:
>> From: Tien Fong Chee <tien.fong.chee at intel.com>
>>
>> Generic firmware loader framework contains some common functionality
>> which is reusable by any specific file system firmware loader.
>>
>> Signed-off-by: Tien Fong Chee <tien.fong.chee at intel.com>
>> ---
>>  common/Makefile   |   2 +
>>  common/load_fs.c  | 163 ++++++++++++++++++++++++++++++++++++++++++++++++++++++
>>  include/load_fs.h |  40 ++++++++++++++
>>  3 files changed, 205 insertions(+)
>>  create mode 100644 common/load_fs.c
>>  create mode 100644 include/load_fs.h
> 
> There is alot of change here and the commit message doesn't tell me
> anything! Please describe, in detail, what your patch is doing.
> 
> Also you need to include more people in the review path for this patch.

And pull it out of the series and convert the splash loader to use this.
It seems my comment about factoring out code from the splash loader was
ignored, sigh ...

> Dinh
> 


-- 
Best regards,
Marek Vasut