[U-Boot] [PATCH v3 06/20] common: Generic firmware loader for file system

[Chee, Tien Fong]

On Isn, 2017-10-16 at 16:41 +0200, Marek Vasut wrote:
> On 10/16/2017 04:08 PM, Dinh Nguyen wrote:
> > 
> > 
> > 
> > On 10/13/2017 03:08 AM, tien.fong.chee at intel.com wrote:
> > > 
> > > From: Tien Fong Chee <tien.fong.chee at intel.com>
> > > 
> > > Generic firmware loader framework contains some common
> > > functionality
> > > which is reusable by any specific file system firmware loader.
> > > 
> > > Signed-off-by: Tien Fong Chee <tien.fong.chee at intel.com>
> > > ---
> > >  common/Makefile   |   2 +
> > >  common/load_fs.c  | 163
> > > ++++++++++++++++++++++++++++++++++++++++++++++++++++++
> > >  include/load_fs.h |  40 ++++++++++++++
> > >  3 files changed, 205 insertions(+)
> > >  create mode 100644 common/load_fs.c
> > >  create mode 100644 include/load_fs.h
> > There is alot of change here and the commit message doesn't tell me
> > anything! Please describe, in detail, what your patch is doing.
> > 
> > Also you need to include more people in the review path for this
> > patch.
These are the code factored out from splash loader, contains some
common functions which can be used by other file system loader such as
fpga loadfs.
Okay, i will include more peoples.
> And pull it out of the series and convert the splash loader to use
> this.
> It seems my comment about factoring out code from the splash loader
> was
> ignored, sigh ...
> 
I didn't ignore your comment, i factored out the common code from
splash loader and put in more generic function name and file name.
Then, i will replace these generic fs loader with splash fs loader at
different patchset.
> > 
> > Dinh
> > 
>