[U-Boot] [PATCH] i2c: remove SYS_ prefix from CONFIG options

[Heiko Schocher]

Hello Masahiro,

Am 17.10.2017 um 15:36 schrieb Masahiro Yamada:
> Historically, U-Boot added CONFIG_SYS_ prefix to user-unconfigurable
> options.  Somehow, this rule was not observed in some places, and
> getting meaningless with Kconfig introduction where platforms can
> "select" to force options.  Actually, I2C drivers are generally
> configurable.
> 
> Convert the options in drivers/i2c/Kconfig.
> 
> This commit was generated by the following command.
> 
> find . -name .git -prune -o -type f -print | \
> xargs sed -i -e '
> s/SYS_I2C_AT91/I2C_AT91/g
> s/SYS_I2C_FSL/I2C_FSL/g
> s/SYS_I2C_CADENCE/I2C_CADENCE/g
> s/SYS_I2C_DW/I2C_DW/g
> s/SYS_I2C_DW_ENABLE_STATUS_UNSUPPORTED/I2C_DW_ENABLE_STATUS_UNSUPPORTED/g
> s/SYS_I2C_ASPEED/I2C_ASPEED/g
> s/SYS_I2C_INTEL/I2C_INTEL/g
> s/SYS_I2C_IMX_LPI2C/I2C_IMX_LPI2C/g
> s/SYS_I2C_MXC/I2C_MXC/g
> s/SYS_I2C_OMAP24XX/I2C_OMAP24XX/g
> s/SYS_I2C_ROCKCHIP/I2C_ROCKCHIP/g
> s/SYS_I2C_SANDBOX/I2C_SANDBOX/g
> s/SYS_I2C_S3C24X0/I2C_S3C24X0/g
> s/SYS_I2C_STM32F7/I2C_STM32F7/g
> s/SYS_I2C_UNIPHIER/I2C_UNIPHIER/g
> s/SYS_I2C_UNIPHIER_F/I2C_UNIPHIER_F/g
> s/SYS_I2C_MVTWSI/I2C_MVTWSI/g
> s/TEGRA186_BPMP_I2C/I2C_TEGRA186_BPMP/g
> s/SYS_I2C_BUS_MAX/I2C_BUS_MAX/g
> '
> 
> Signed-off-by: Masahiro Yamada <yamada.masahiro at socionext.com>


Thanks ... but why do you not convert all symbols?

With your patch there are now CONFIG_I2C and CONFIG_SYS_I2C symbols
mixed. Please send another patch where you convert the missing:

SYS_I2C_ADI
SYS_I2C
SYS_I2C_DAVINCI
SYS_I2C_FTI2C010
SYS_I2C_IHS
SYS_I2C_KONA
SYS_I2C_LPC32XX
SYS_I2C_MXS
SYS_I2C_RCAR
SYS_I2C_SH
SYS_I2C_SOFT
SYS_I2C_TEGRA
SYS_I2C_ZYNQ

Beside of this I like this change.

bye,
Heiko

bye,
Heiko
-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-52   Fax: +49-8142-66989-80   Email: hs at denx.de