[U-Boot] [PATCH] i2c: remove SYS_ prefix from CONFIG options

[Masahiro Yamada]

Hi Heiko,


2017-10-19 13:38 GMT+09:00 Heiko Schocher <hs at denx.de>:
> Hello Masahiro,
>
>
> Am 17.10.2017 um 15:36 schrieb Masahiro Yamada:
>>
>> Historically, U-Boot added CONFIG_SYS_ prefix to user-unconfigurable
>> options.  Somehow, this rule was not observed in some places, and
>> getting meaningless with Kconfig introduction where platforms can
>> "select" to force options.  Actually, I2C drivers are generally
>> configurable.
>>
>> Convert the options in drivers/i2c/Kconfig.
>>
>> This commit was generated by the following command.
>>
>> find . -name .git -prune -o -type f -print | \
>> xargs sed -i -e '
>> s/SYS_I2C_AT91/I2C_AT91/g
>> s/SYS_I2C_FSL/I2C_FSL/g
>> s/SYS_I2C_CADENCE/I2C_CADENCE/g
>> s/SYS_I2C_DW/I2C_DW/g
>> s/SYS_I2C_DW_ENABLE_STATUS_UNSUPPORTED/I2C_DW_ENABLE_STATUS_UNSUPPORTED/g
>> s/SYS_I2C_ASPEED/I2C_ASPEED/g
>> s/SYS_I2C_INTEL/I2C_INTEL/g
>> s/SYS_I2C_IMX_LPI2C/I2C_IMX_LPI2C/g
>> s/SYS_I2C_MXC/I2C_MXC/g
>> s/SYS_I2C_OMAP24XX/I2C_OMAP24XX/g
>> s/SYS_I2C_ROCKCHIP/I2C_ROCKCHIP/g
>> s/SYS_I2C_SANDBOX/I2C_SANDBOX/g
>> s/SYS_I2C_S3C24X0/I2C_S3C24X0/g
>> s/SYS_I2C_STM32F7/I2C_STM32F7/g
>> s/SYS_I2C_UNIPHIER/I2C_UNIPHIER/g
>> s/SYS_I2C_UNIPHIER_F/I2C_UNIPHIER_F/g
>> s/SYS_I2C_MVTWSI/I2C_MVTWSI/g
>> s/TEGRA186_BPMP_I2C/I2C_TEGRA186_BPMP/g
>> s/SYS_I2C_BUS_MAX/I2C_BUS_MAX/g
>> '
>>
>> Signed-off-by: Masahiro Yamada <yamada.masahiro at socionext.com>
>
>
>
> Thanks ... but why do you not convert all symbols?
>

Good question.

I thought legacy options should
be moved to Kconfig and renamed at the same time.
I prefer one-time churn to twice.


I sometimes do that.
For example, commit 1d2c0506d31a9997e5ffc22e90942902f673b107


I assume your next question about Kconfig move.

Yeah, if I find some time this week,
I think I can do rename-and-move for the rest of options.

-- 
Best Regards
Masahiro Yamada