[U-Boot] [PATCH v3 1/2] thermal: ti-bandgap: Add support for temperature sensor

[Tom Rini]

On Mon, Oct 23, 2017 at 10:50:15AM +0530, Faiz Abbas wrote:
> Hi Tom,
> 
> On Monday 23 October 2017 08:30 AM, Tom Rini wrote:
> > On Mon, Oct 23, 2017 at 08:07:09AM +0530, Lokesh Vutla wrote:
> >> On Wednesday 18 October 2017 05:11 PM, Faiz Abbas wrote:
> >>> The dra7xx series of SOCs contain a temperature sensor and an
> >>> associated analog-to-digital converter (ADC) which produces
> >>> an output which is proportional to the SOC temperature.
> >>> Add support for this temperature sensor.
> >>>
> >>> Signed-off-by: Faiz Abbas <faiz_abbas at ti.com>
> >>> Reviewed-by: Simon Glass <sjg at chromium.org>
> >>> ---
> >>> v3:
> >>> Added Reviewed-by comment
> >>>
> >>> v2:
> >>>  1. Removed extra elements from ti_bandgap
> >>>  2. Changed base address to ulong
> >>>  3. Changed to udev to dev to maintain consistency
> >>>  4. minor format changes
> >>>
> >>>  common/spl/Kconfig                                 |   8 +
> >>>  configs/dra7xx_evm_defconfig                       |   3 +
> >>>  .../thermal/ti_soc_thermal.txt                     |  35 ++++
> >>>  drivers/Makefile                                   |   2 +-
> >>>  drivers/thermal/Kconfig                            |   6 +
> >>>  drivers/thermal/Makefile                           |   1 +
> >>>  drivers/thermal/ti-bandgap.c                       | 197 +++++++++++++++++++++
> >>>  7 files changed, 251 insertions(+), 1 deletion(-)
> >>>  create mode 100644 doc/device-tree-bindings/thermal/ti_soc_thermal.txt
> >>>  create mode 100644 drivers/thermal/ti-bandgap.c
> >>>
> >>> diff --git a/common/spl/Kconfig b/common/spl/Kconfig
> >>> index 0bd8370..0bf3ee3 100644
> >>> --- a/common/spl/Kconfig
> >>> +++ b/common/spl/Kconfig
> >>> @@ -604,6 +604,14 @@ config SPL_SPI_SUPPORT
> >>>  	  enable SPI drivers that are needed for other purposes also, such
> >>>  	  as a SPI PMIC.
> >>>  
> >>> +config SPL_THERMAL
> >>> +	bool "Driver support for thermal devices"
> >>> +	help
> >>> +	  Enable support for temperature-sensing devices. Some SoCs have on-chip
> >>> +	  temperature sensors to permit warnings, speed throttling or even
> >>> +	  automatic power-off when the temperature gets too high or low. Other
> >>> +	  devices may be discrete but connected on a suitable bus.
> >>> +
> >>>  config SPL_USB_HOST_SUPPORT
> >>>  	bool "Support USB host drivers"
> >>>  	help
> >>> diff --git a/configs/dra7xx_evm_defconfig b/configs/dra7xx_evm_defconfig
> >>> index 468c288..447fb89 100644
> >>> --- a/configs/dra7xx_evm_defconfig
> >>> +++ b/configs/dra7xx_evm_defconfig
> >>> @@ -90,3 +90,6 @@ CONFIG_USB_GADGET=y
> >>>  CONFIG_USB_GADGET_MANUFACTURER="Texas Instruments"
> >>>  CONFIG_USB_GADGET_VENDOR_NUM=0x0451
> >>>  CONFIG_USB_GADGET_PRODUCT_NUM=0xd022
> >>> +CONFIG_SPL_THERMAL=y
> >>> +CONFIG_DM_THERMAL=y
> >>> +CONFIG_TI_DRA7_THERMAL=y
> >>
> >> Tom,
> >> 	Do you want these options to be implied so that it will take effect for
> >> HS board as well. Or enable it in defconfig as is?
> > 
> > How important is it that this be enabled?  Is this 100% within the SoC?
> > Thanks!
> > 
> 
> There is an upcoming errata which requires temperature support to
> workaround. This errata will apply to the HS boards as well. Will send a
> new patch with imply added to TARGET_DRA7XX_EVM for these configs.

Well, can you _not_ have this support enabled, on the dra7xx family?  If
it must be always there, please select it.  Otherwise imply is OK.
Thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20171023/9aec87dc/attachment.sig>